Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backports #22402 and #22412 to 4.x-dev #22475

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Backports #22402 and #22412 to 4.x-dev #22475

merged 2 commits into from
Aug 5, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Aug 5, 2024

Description:

Review

@sgiehl
Improve URL check for logme redirect (#22402)
afeaa16 
* Improve URL check for redirect

* adds regression test
@sgiehl
Improve validity check for redirect urls (#22412)
f7c5ed4 
* Improve validity check for redirect urls

* Adds regression test
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Aug 5, 2024
@sgiehl sgiehl requested a review from a team August 5, 2024 13:51
@sgiehl sgiehl added this to the 4.16.2 milestone Aug 5, 2024
@mneudert mneudert merged commit 8669feb into 4.x-dev Aug 5, 2024
17 of 26 checks passed
@mneudert mneudert deleted the applyredirectfixes4x branch August 5, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mneudert mneudert mneudert approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.16.2
Development

Successfully merging this pull request may close these issues.
2 participants
@sgiehl @mneudert