-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating dependencies for PHP 8.3 support #488
Conversation
The failing UI test cases are due to the core navigation shadow change and we're waiting for a long term fix before we update the screenshots. So, I think that we're good to merge once the changes are reviewed/approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snake14 I checked the code for PHP 8.3 and the error goes away for GA plugin, but I am still seeing an error for SearchEngineKeyword plugin, which shouldn't be the case at all as we are prefixing the vendor libraries
@AltamashShaikh I wasn't able to reproduce that issue with the SEKP warnings, but I did fix the issue with the dynamic property warnings from PHP 8.3. It was an issue with the transpiling process removing the |
@snake14 I can confirm the error goes away 👍 |
Description:
We've been waiting for Google to release an update for PHP 8.3 support. This updates our dependencies to include that update and a few others.
Review