Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating dependencies for PHP 8.3 support #488

Merged
merged 11 commits into from
Jan 18, 2024

Conversation

snake14
Copy link
Contributor

@snake14 snake14 commented Jan 15, 2024

Description:

We've been waiting for Google to release an update for PHP 8.3 support. This updates our dependencies to include that update and a few others.

Review

@snake14
Copy link
Contributor Author

snake14 commented Jan 16, 2024

The failing UI test cases are due to the core navigation shadow change and we're waiting for a long term fix before we update the screenshots. So, I think that we're good to merge once the changes are reviewed/approved.

Copy link
Contributor

@AltamashShaikh AltamashShaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snake14 I checked the code for PHP 8.3 and the error goes away for GA plugin, but I am still seeing an error for SearchEngineKeyword plugin, which shouldn't be the case at all as we are prefixing the vendor libraries

Screenshot from 2024-01-17 08-59-04

@snake14
Copy link
Contributor Author

snake14 commented Jan 17, 2024

@AltamashShaikh I wasn't able to reproduce that issue with the SEKP warnings, but I did fix the issue with the dynamic property warnings from PHP 8.3. It was an issue with the transpiling process removing the #[\AllowDynamicProperties] attribute from some of the Google classes.

@AltamashShaikh
Copy link
Contributor

@AltamashShaikh I wasn't able to reproduce that issue with the SEKP warnings, but I did fix the issue with the dynamic property warnings from PHP 8.3. It was an issue with the transpiling process removing the #[\AllowDynamicProperties] attribute from some of the Google classes.

@snake14 I can confirm the error goes away 👍

@snake14 snake14 merged commit b9715b5 into 5.x-dev Jan 18, 2024
4 of 5 checks passed
@snake14 snake14 deleted the pg-3131-update-google-dependency branch January 18, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants