Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textual change for Tracking code generator page #618

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Textual change for Tracking code generator page.
Fixes: #PG-2730

Review

@@ -166,7 +166,7 @@ export default defineComponent({
.timepicker({ timeFormat: 'H:i:s' })
// timepicker triggers a jquery event, not a addEventListener event, so vue doesn't catch
// it
.on('change', (event) => {
.on('change', (event: ChangeEvent) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./console vue:build TagManager was failing and had to update as below to make it work

TagManager.php Outdated Show resolved Hide resolved
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and I was able to view the title change in the tracking code view.

@AltamashShaikh AltamashShaikh merged commit c31cfe2 into 5.x-dev Apr 14, 2023
@AltamashShaikh AltamashShaikh deleted the PG-2730-update-name branch April 14, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants