Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code to remove All websites from site selector dropdown, #PG-3196 #770

Merged
merged 3 commits into from
Mar 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions templates/manageContainers.twig
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
<div
vue-entry="CoreHome.SiteSelector"
show-selected-site="true"
show-all-sites-item="false"
class="sites_autocomplete"
></div>
</div>
Expand Down
1 change: 1 addition & 0 deletions templates/tagmanager.twig
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
<div
vue-entry="CoreHome.SiteSelector"
show-selected-site="true"
show-all-sites-item="false"
class="sites_autocomplete"
></div>
</div>
Expand Down
7 changes: 7 additions & 0 deletions tests/UI/Container_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,13 @@ describe("Container", function () {
expect(await pageWrap.screenshot()).to.matchImage('site_some_exist');
});

it('should show websites dropdown without all websites', async function () {
await page.evaluate(() => $('.top_bar_sites_selector .siteSelector a.title').click());
pageWrap = await page.$('.top_bar_sites_selector .dropdown');
expect(await pageWrap.screenshot()).to.matchImage('websites_dropdown_without_all_websites');
await page.evaluate(() => $('.top_bar_sites_selector .siteSelector a.title').click());
});

it('should be able to create a new container', async function () {
await page.click('.createNewContainer');
await capture.setTableRowHeight(page);
Expand Down
7 changes: 7 additions & 0 deletions tests/UI/TagManager_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,13 @@ describe("TagManager", function () {
await capture.page(page, 'getting_started');
});

it('should show websites dropdown without all websites', async function () {
await page.evaluate(() => $('.top_bar_sites_selector .siteSelector a.title').click());
pageWrap = await page.$('.top_bar_sites_selector .dropdown');
expect(await pageWrap.screenshot()).to.matchImage('websites_dropdown_without_all_websites');
await page.evaluate(() => $('.top_bar_sites_selector .siteSelector a.title').click());
});

it('should show top bar list when no container exists', async function () {
await page.goto(generalParamsSite5 + urlBase + 'gettingStarted');
await capture.topControls(page, 'top_controls_no_container_exists');
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading