Hide publish button for user without tagmanager_use_custom_templates capability

API.php

@@ -1031,6 +1031,7 @@ public function createContainerVersion($idSite, $idContainer, $name, $descriptio
     {
         $name = $this->decodeQuotes($name);
         $this->accessValidator->checkWriteCapability($idSite);
+        $this->accessValidator->checkUseCustomTemplatesCapability($idSite);
         $this->containers->checkContainerExists($idSite, $idContainer);
 
         if (empty($idContainerVersion)) {
@@ -1058,6 +1059,7 @@ public function updateContainerVersion($idSite, $idContainer, $idContainerVersio
     {
         $name = $this->decodeQuotes($name);
         $this->accessValidator->checkWriteCapability($idSite);
+        $this->accessValidator->checkUseCustomTemplatesCapability($idSite);
         $this->containers->checkContainerVersionExists($idSite, $idContainer, $idContainerVersion);
 
         return $this->containers->updateContainerVersion($idSite, $idContainer, $idContainerVersion, $name, $description);

Controller.php

@@ -231,6 +231,9 @@ public function manageVariables()
 
     public function manageVersions()
     {
+        $idSite = Common::getRequestVar('idSite', null, 'int');
+        $this->accessValidator->checkWriteCapability($idSite);
+        $this->accessValidator->checkUseCustomTemplatesCapability($idSite);
         $path = TagManager::getAbsolutePathToContainerDirectory();
         Filechecks::dieIfDirectoriesNotWritable(array($path));
         $versionsHelpText = $this->renderTemplate('helpContent', [

Menu.php

@@ -103,7 +103,6 @@ public function configureTagManagerMenu(MenuTagManager $menu)
                 $menu->addItem($menuCategory, 'TagManager_Tags', $this->urlForAction('manageTags', $params), $orderId = 105);
                 $menu->addItem($menuCategory, 'TagManager_Triggers', $this->urlForAction('manageTriggers', $params), $orderId = 110);
                 $menu->addItem($menuCategory, 'TagManager_Variables', $this->urlForAction('manageVariables', $params), $orderId = 115);
-                $menu->addItem($menuCategory, 'TagManager_Versions', $this->urlForAction('manageVersions', $params), $orderId = 115);
 
                 $previewEnabled = false;
                 foreach ($container['releases'] as $release) {
@@ -119,7 +118,10 @@ public function configureTagManagerMenu(MenuTagManager $menu)
                         $menu->addItem($menuCategory, 'TagManager_EnablePreviewDebug', array(), $orderId = 130, false,'icon-bug', "tagManagerHelper.enablePreviewMode(" . json_encode($container['idcontainer']) . ")");
                     }
 
-                    $menu->addItem($menuCategory, 'TagManager_Publish', array(), $orderId = 135, false, 'icon-rocket', "tagManagerHelper.editVersion(" . json_encode($container['idcontainer']) . ", 0, function () { window.location.reload(); })");
+                    if ($this->accessValidator->hasUseCustomTemplatesCapability($idSite)) {
+                        $menu->addItem($menuCategory, 'TagManager_Versions', $this->urlForAction('manageVersions', $params), $orderId = 115);
+                        $menu->addItem($menuCategory, 'TagManager_Publish', array(), $orderId = 135, false, 'icon-rocket', "tagManagerHelper.editVersion(" . json_encode($container['idcontainer']) . ", 0, function () { window.location.reload(); })");
+                    }
                 }
                 $menu->addItem($menuCategory, 'TagManager_InstallCode', $this->urlForAction('releases', $params), $orderId = 140, false,'icon-embed', "tagManagerHelper.showInstallCode(" . json_encode($container['idcontainer']) . ")");
 

tests/UI/ContainerVersion_spec.js

@@ -232,19 +232,6 @@ describe("ContainerVersion", function () {
         await capture.page(page, 'debug_version_enable');
     });
 
-    it('should load versions page with some versions as view user', async function () {
-        permissions.setViewUser();
-        await page.goto(container1Base);
-        await capture.page(page, 'version_some_exist_view_user');
-    });
-
-    it('should load versions page with no versions as view user', async function () {
-        permissions.setViewUser();
-        await page.goto(container3Base);
-        await page.waitForSelector('.manageVersion', { visible: true });
-        await capture.selector(page, 'version_none_exist_view_user', '.manageVersion');
-    });
-
     it('should be able to show import version screen', async function () {
         await page.goto(container1Base);
         await page.click('.importVersion');
@@ -273,19 +260,4 @@ describe("ContainerVersion", function () {
         await page.waitForTimeout(200);
         await capture.page(page, 'import_version_confirmed');
     });
-
-    it('should show notice not possible to publish to live container and preselect alternative environment', async function () {
-        permissions.setWriteUser();
-        await page.goto(container1Base);
-        await page.click('.createNewVersion');
-        await page.waitForNetworkIdle();
-        await capture.page(page, 'no_publish_live_container_capability');
-    });
-
-    it('should show notice not possible to publish to live container and preselect alternative environment in selector', async function () {
-        permissions.setWriteUser();
-        await page.goto(container1Base);
-        await clickFirstRowTableAction('icon-rocket');
-        await capture.modal(page, 'no_publish_live_container_capability_selector');
-    });
 });