Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove backend matplotlib.use('nbagg') and add ipympl #33

Closed
wants to merge 4 commits into from
Closed

remove backend matplotlib.use('nbagg') and add ipympl #33

wants to merge 4 commits into from

Conversation

hasibzunair
Copy link

Addresses #32

@hasibzunair hasibzunair mentioned this pull request Oct 27, 2019
Open
tacaswell
tacaswell reviewed Oct 28, 2019
View reviewed changes
AnatomyOfMatplotlib-Part1-Figures_Subplots_and_layouts.ipynb
@@ -87,33 +90,9 @@
"cell_type": "markdown",
"metadata": {},
"source": [
"If you are working interactively at an (I)python prompt, the GUI framework is not critical (mostly aesthetic) however when working in Jupyter we need to pick a backend that integrates with Jupyter (javascript) framework.\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still useful content for people who will are reading this that will mostly work at a prompt. Can it just be re-worrked rather than fully deleted?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added that part back. Hope that's fine.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this alright, or needs rephrasing?

@tacaswell
Copy link
Member

I don't see where these changes are using the widget backend.

@hasibzunair
Copy link
Author

They aren't if I am not wrong. I removed the nbagg backend and installed the ipympl it seems to work fine for these notebooks. The issue for the %matplotlib widget still remains.

@tacaswell
Copy link
Member

I removed the nbagg backend and installed the ipympl it seems to work fine for these notebooks

If you are not getting interactive figures (can you pan / zoom?) then things are not working correctly.

@hasibzunair
Copy link
Author

I have fixed the widget issue by running the following bash commands:

conda install -y nodejs
pip install --upgrade jupyterlab
jupyter labextension install @jupyter-widgets/jupyterlab-manager
jupyter labextension install jupyter-matplotlib
jupyter nbextension enable --py widgetsnbextension

I get interactive figures now.

@hasibzunair
Copy link
Author

Merge possible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hasibzunair @tacaswell