FIX: remove try, add test

matplotlib · Jul 9, 2020 · a7abf30 · a7abf30
1 parent 455fbeb
commit a7abf30
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/lib/matplotlib/rcsetup.py b/lib/matplotlib/rcsetup.py
@@ -183,22 +183,16 @@ def _validate_date_converter(s):
         cbook._warn_external(f'date.converter string must be "auto" '
                              f'or "concise", not "{s}".  Check your '
                              'matplotlibrc')
-    try:
-        import matplotlib.dates as mdates
-        mdates._rcParam_helper.set_converter(s)
-    except Exception as e:
-        pass
+    import matplotlib.dates as mdates
+    mdates._rcParam_helper.set_converter(s)
 
 
 def _validate_date_int_mult(s):
     if s is None:
         return
     s = validate_bool(s)
-    try:
-        import matplotlib.dates as mdates
-        mdates._rcParam_helper.set_int_mult(s)
-    except Exception as e:
-        pass
+    import matplotlib.dates as mdates
+    mdates._rcParam_helper.set_int_mult(s)
 
 
 def _validate_tex_preamble(s):

diff --git a/lib/matplotlib/tests/test_dates.py b/lib/matplotlib/tests/test_dates.py
@@ -977,6 +977,8 @@ def test_change_converter():
     fig.canvas.draw()
     assert ax.get_xticklabels()[0].get_text() == 'Jan 01 2020'
     assert ax.get_xticklabels()[1].get_text() == 'Jan 15 2020'
+    with pytest.warns(UserWarning) as rec:
+        plt.rcParams['date.converter'] = 'boo'
 
 
 def test_change_interval_multiples():