Merge pull request #1964 from cimarronm/data_spine_right_top_location…

…_fix Fixes issue #1960. Account for right/top spine data offset on transform ...
matplotlib · May 11, 2013 · af07100 · af07100
2 parents 1f07cb8 + 6f45b43
commit af07100
Show file tree

Hide file tree

Showing 6 changed files with 564 additions and 0 deletions.
diff --git a/doc/api/api_changes.rst b/doc/api/api_changes.rst
@@ -15,6 +15,10 @@ For new features that were added to matplotlib, please see
 Changes in 1.3.x
 ================
 
+* Fixed a bug in setting the position for the right/top spine with data 
+  position type. Previously, it would draw the right or top spine at
+  +1 data offset.
+
 * In :class:`~matplotlib.patches.FancyArrow`, the default arrow head width,
   ``head_width``, has been made larger to produce a visible arrow head. The new
   value of this kwarg is ``head_width = 20 * width``.

diff --git a/lib/matplotlib/spines.py b/lib/matplotlib/spines.py
@@ -323,6 +323,11 @@ def _calc_offset_transform(self):
                 self._spine_transform = ('identity',
                                          mtransforms.IdentityTransform())
         elif position_type == 'data':
+            if self.spine_type in ('right', 'top'):
+                # The right and top spines have a default position of 1 in
+                # axes coordinates.  When specifying the position in data
+                # coordinates, we need to calculate the position relative to 0.
+                amount -= 1
             if self.spine_type in ('left', 'right'):
                 self._spine_transform = ('data',
                                          mtransforms.Affine2D().translate(

diff --git a/lib/matplotlib/tests/baseline_images/test_spines/spines_data_positions.pdf b/lib/matplotlib/tests/baseline_images/test_spines/spines_data_positions.pdf
diff --git a/lib/matplotlib/tests/baseline_images/test_spines/spines_data_positions.png b/lib/matplotlib/tests/baseline_images/test_spines/spines_data_positions.png