Open files in binary mode.

matplotlib · Jan 11, 2013 · dda9b7a · dda9b7a
1 parent c3d39b5
commit dda9b7a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/_backend_agg.cpp b/src/_backend_agg.cpp
@@ -2034,7 +2034,7 @@ RendererAgg::write_rgba(const Py::Tuple& args)
 
     if (py_fileobj.isString())
     {
-        if ((py_file = npy_PyFile_OpenFile(py_fileobj.ptr(), (char *)"w")) == NULL) {
+        if ((py_file = npy_PyFile_OpenFile(py_fileobj.ptr(), (char *)"wb")) == NULL) {
             throw Py::Exception();
         }
         close_file = true;
@@ -2044,7 +2044,7 @@ RendererAgg::write_rgba(const Py::Tuple& args)
         py_file = py_fileobj.ptr();
     }
 
-    if ((fp = npy_PyFile_Dup(py_file, (char *)"w")))
+    if ((fp = npy_PyFile_Dup(py_file, (char *)"wb")))
     {
         if (fwrite(pixBuffer, 1, NUMBYTES, fp) != NUMBYTES)
         {

diff --git a/src/_png.cpp b/src/_png.cpp
@@ -133,7 +133,7 @@ Py::Object _png_module::write_png(const Py::Tuple& args)
     PyObject* py_file = NULL;
     if (py_fileobj.isString())
     {
-        if ((py_file = npy_PyFile_OpenFile(py_fileobj.ptr(), (char *)"w")) == NULL) {
+        if ((py_file = npy_PyFile_OpenFile(py_fileobj.ptr(), (char *)"wb")) == NULL) {
             throw Py::Exception();
         }
         close_file = true;
@@ -143,7 +143,7 @@ Py::Object _png_module::write_png(const Py::Tuple& args)
         py_file = py_fileobj.ptr();
     }
 
-    if ((fp = npy_PyFile_Dup(py_file, (char *)"w")))
+    if ((fp = npy_PyFile_Dup(py_file, (char *)"wb")))
     {
         close_dup_file = true;
     }
@@ -313,15 +313,15 @@ _png_module::_read_png(const Py::Object& py_fileobj, const bool float_result,
 
     if (py_fileobj.isString())
     {
-        if ((py_file = npy_PyFile_OpenFile(py_fileobj.ptr(), (char *)"r")) == NULL) {
+        if ((py_file = npy_PyFile_OpenFile(py_fileobj.ptr(), (char *)"rb")) == NULL) {
             throw Py::Exception();
         }
         close_file = true;
     } else {
         py_file = py_fileobj.ptr();
     }
 
-    if ((fp = npy_PyFile_Dup(py_file, "r")))
+    if ((fp = npy_PyFile_Dup(py_file, "rb")))
     {
         close_dup_file = true;
     }