Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legend.get_window_extent now requires a renderer #11970

Closed
tacaswell opened this issue Aug 29, 2018 · 0 comments · Fixed by #11971
Closed

Legend.get_window_extent now requires a renderer #11970

tacaswell opened this issue Aug 29, 2018 · 0 comments · Fixed by #11971
Assignees
@jklymak
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Milestone
v3.0.0

Comments

@tacaswell
Copy link
Member

See mwaskom/seaborn#1551

import matplotlib.pyplot as plt

leg = plt.legend()
plt.gcf().canvas.draw()
leg.get_window_extent()

The issue seems to be that #10910 switched which of the children from a patch (which seems to not actually need a renderer to sort out it's size) and a Vpacker (which fixes another bug, but really does need the renderer).
@tacaswell tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Aug 29, 2018
@tacaswell tacaswell added this to the v3.0 milestone Aug 29, 2018
tacaswell added a commit to tacaswell/matplotlib that referenced this issue Aug 29, 2018
@tacaswell
FIX: use cached renderer on Legend.get_window_extent
619563b 
Closes matplotlib#11970
tacaswell added a commit to tacaswell/matplotlib that referenced this issue Aug 29, 2018
@tacaswell
FIX: use cached renderer on Legend.get_window_extent
9f27f65 
Closes matplotlib#11970
tacaswell added a commit to tacaswell/matplotlib that referenced this issue Aug 29, 2018
@tacaswell
FIX: use cached renderer on Legend.get_window_extent
e1e4307 
Closes matplotlib#11970
@tacaswell tacaswell mentioned this issue Aug 29, 2018
Merged
6 tasks
tacaswell added a commit to tacaswell/matplotlib that referenced this issue Aug 29, 2018
@tacaswell
FIX: use cached renderer on Legend.get_window_extent
873ae23 
Closes matplotlib#11970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jklymak jklymak

Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

FIX: use cached renderer on Legend.get_window_extent tacaswell/matplotlib
2 participants
@tacaswell @jklymak