Alternate implementation of lazy ticks. #10302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
reviewed
Jan 23, 2018
anntzer
force-pushed
the
lazyticks
branch
2 times, most recently
from
e2c7538
to
ce2ddee
Compare
timhoffm
approved these changes
Jan 24, 2018
1 task
jklymak
approved these changes
Jan 24, 2018
jklymak
added
the
Release critical
|
I'm not going to merge in case @efiring or @tacaswell want to have a look.... |
|
ooops, now there is a conflict. Probably w/ the other tick change? |
Speeds up creation of 10x10 subplots ~4-fold (from 2.7s to 0.7s).
|
rebased |
|
@timhoffm congrats on getting your commit bit, btw |
|
@timhoffm Yes, welcome! Though I think out of an abundance of caution we make sure (most of) the tests pass before committing 😉 Maybe OK in this case, as the pre-rebase passed, but... |
|
Thanks. @jklymak also thanks for the advice. I will wait next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speeds up creation of 10x10 subplots ~4-fold (from 2.7s to 0.7s for me).
I think this is closer than #9727 to being backcompatible, and also simpler if you understand how descriptors work. attn @timhoffm, obviously the credits of the idea go to him.
Milestoned to 2.2 to match #9727.
PR Summary
PR Checklist