the affine matrix is calculated in the display coordinate for interpolation='none' #1150

Merged
merged 3 commits into from Sep 5, 2012

Conversation

Projects
None yet
4 participants
@leejjoon
Contributor

leejjoon commented Aug 27, 2012

For images with interpolation='none', the affine matrix is now calculated in the display coordinate.
This is to simplify the matrix that renderers receives.
This is to address #1085.

@pelson

This comment has been minimized.

Show comment Hide comment
@pelson

pelson Sep 2, 2012

Member

If you have code that was failing, but is now fixed, it would be great to get a test for this new code.

Member

pelson commented Sep 2, 2012

If you have code that was failing, but is now fixed, it would be great to get a test for this new code.

@mdboom

This comment has been minimized.

Show comment Hide comment
@mdboom

mdboom Sep 4, 2012

Owner

I'd love to see this go into 1.2.x. I will try to whip up a test based on #1085 for this.

Owner

mdboom commented Sep 4, 2012

I'd love to see this go into 1.2.x. I will try to whip up a test based on #1085 for this.

@mdboom

This comment has been minimized.

Show comment Hide comment
@mdboom

mdboom Sep 4, 2012

Owner

I've added a test as a PR against @leejjoon's branch.

Owner

mdboom commented Sep 4, 2012

I've added a test as a PR against @leejjoon's branch.

@travisbot

This comment has been minimized.

Show comment Hide comment
@travisbot

travisbot Sep 5, 2012

This pull request fails (merged 67eb71d into 94c53e1).

This pull request fails (merged 67eb71d into 94c53e1).

@pelson

This comment has been minimized.

Show comment Hide comment
@pelson

pelson Sep 5, 2012

Member

+1

Member

pelson commented Sep 5, 2012

+1

mdboom added a commit that referenced this pull request Sep 5, 2012

Merge pull request #1150 from leejjoon/fix-image-shift
the affine matrix is calculated in the display coordinate for interpolation='none'

@mdboom mdboom merged commit 2e5a38a into matplotlib:master Sep 5, 2012

1 check failed

default The Travis build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment