Cleanup Legend._auto_legend_data. #16302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
force-pushed
the
autolegenddata
branch
from
f5cf954
to
c6a73b3
Compare
timhoffm
reviewed
Jan 23, 2020
Fix the docstring, which was wrong. Use shorter list comprehensions to construct `vertices` and `bboxes`. Clarify the failure mode of `np.concatenate`. Remove an unnecessary check when constructing `offsets`.
anntzer
force-pushed
the
autolegenddata
branch
from
c6a73b3
to
f052d1e
Compare
timhoffm
approved these changes
Jan 24, 2020
tacaswell
reviewed
Jan 25, 2020
|
|
||
| return [vertices, bboxes, lines, offsets] | ||
| _, transOffset, hoffsets, _ = handle._prepare_points() | ||
| for offset in transOffset.transform(hoffsets): |
There was a problem hiding this comment.
Are we sure this is happy with 0-length hoffsets?
There was a problem hiding this comment.
scatter([], [], label="foo"); legend() creates a 0-length hoffsets and works fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the docstring, which was wrong.
Use shorter list comprehensions to construct
verticesandbboxes.Clarify the failure mode of
np.concatenate. Remove an unnecessarycheck when constructing
offsets.PR Summary
PR Checklist