Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprint: Added new external resources page, link from main and content pages #2165

Merged
merged 2 commits into from Jul 19, 2013

Conversation

alsaihn
Copy link
Contributor

@alsaihn alsaihn commented Jun 28, 2013

Sprint: Added new external resources page, link from main and content pages

Used link suggestions from #949, the main page and http://stackoverflow.com/questions/3872802/good-matplotlib-documentation-recommendation

an <a href="http://www.youtube.com/watch?v=3Fp1zn5ao2M&feature=plcp">introductory
tutorial on Numpy and matplotlib</a> at SciPy 2012.</li>
</ul>
<p>Check the <a href="{{ pathto('resources/index') }}">external resources</a> page</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can change this to: There are many <a href="{{ pathto('resources/index') }}">external learning resources about matplotlib</a> available, including printed material, videos and tutorials..

Any other comments?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a good suggestion.

@pelson
Copy link
Member

pelson commented Jun 29, 2013

Nice addition. I think we can work on the front page wording, but other than that, it looks good to me!

Books and Chapters
===================

* `Matplotlib for Python Developers <http://www.packtpub.com/matplotlib-python-development/book?mid/171109cna1h>`_ by Sandro Tosi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope this doesn't sound too nitpicky, but could you wrap these lines to 80 characters?

@mdboom
Copy link
Member

mdboom commented Jun 29, 2013

This is great. This will give us a nice spot to put more of these. We need to be better at updating this list on a regular basis. But let's get this in and just add things as we find them.

@pelson
Copy link
Member

pelson commented Jun 29, 2013

We need to be better at updating this list on a regular basis.

@WeatherGod's tutorial this week for example. 😉

@mdboom
Copy link
Member

mdboom commented Jul 1, 2013

@alsaihn: Just in case you don't know: You can make these suggested changes, push them to the same branch on your fork, and this PR will automatically update. We can then review again, and we'd love to have this contribution! Thanks.

@pelson
Copy link
Member

pelson commented Jul 15, 2013

@alsaihn - this is a great addition which I'm keen to merge. If you could just update your branch with the suggested changes, I think we are good to go.

Thanks!

@alsaihn
Copy link
Contributor Author

alsaihn commented Jul 19, 2013

Sorry this took so long, but all the above changes have been made. Glad to help ^_^

@NelleV
Copy link
Member

NelleV commented Jul 19, 2013

Thank you!

NelleV added a commit that referenced this pull request Jul 19, 2013
Sprint: Added new external resources page, link from main and content pages
@NelleV NelleV merged commit 5497d47 into matplotlib:master Jul 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants