Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cursor_demo wrt. Line2D.set_x/ydata not accepting scalars anymore. #25106

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 29, 2023

Trying to run the example prior to the PR would result in exceptions being thrown on mouse moves.

PR Summary

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

Trying to run the example prior to the PR would result in exceptions
being thrown on mouse moves.
@anntzer anntzer added Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labels Jan 29, 2023
@anntzer anntzer added this to the v3.7.0 milestone Jan 29, 2023
@story645 story645 merged commit f10d0d1 into matplotlib:main Jan 29, 2023
@lumberbot-app
Copy link

lumberbot-app bot commented Jan 29, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.7.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 f10d0d16a7ff0dc622f388dac5090029af2f017f
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #25106: Fix cursor_demo wrt. Line2D.set_x/ydata not accepting scalars anymore.'
  1. Push to a named branch:
git push YOURFORK v3.7.x:auto-backport-of-pr-25106-on-v3.7.x
  1. Create a PR against branch v3.7.x, I would have named this PR:

"Backport PR #25106 on branch v3.7.x (Fix cursor_demo wrt. Line2D.set_x/ydata not accepting scalars anymore.)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@anntzer anntzer deleted the cd branch January 29, 2023 21:51
ksunden pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 6, 2023
Trying to run the example prior to the PR would result in exceptions
being thrown on mouse moves.

Manual backport of matplotlib#25106 rolled into backport of matplotlib#25129 (backport pr matplotlib#25160)
@ksunden
Copy link
Member

ksunden commented Feb 6, 2023

Manual backport rolled into #25160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants