Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin mpl-sphinx-theme on the v3.7.x branch #25307

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Feb 23, 2023

PR Summary

A similar thing was done for the v3.6.x branch.

PR Checklist

Documentation and Tests

  • [n/a] Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] New plotting related features are documented with examples.

Release Notes

  • [n/a] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [n/a] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • [n/a] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@QuLogic QuLogic added the Documentation: build building the docs label Feb 23, 2023
@QuLogic QuLogic added this to the v3.7.1 milestone Feb 23, 2023
@tacaswell
Copy link
Member

This should also go in the release guide updates?

@QuLogic
Copy link
Member Author

QuLogic commented Feb 23, 2023

Yes, probably; cc @ksunden

@QuLogic QuLogic changed the title Pin mpl-shinx-theme for v3.7.x branch Pin mpl-sphinx-theme on the v3.7.x branch Feb 23, 2023
@ksunden
Copy link
Member

ksunden commented Feb 23, 2023

Is there any reason not to pin this way on main? Its our own first party dependency that we control the release cycle of. While we currently version it for every (feature) release, it could in theory slow down that it doesn't need to be updated for each mpl release.

I feel like updating the pin is already a part of the theme release (we only updated it because we want to change/fix something, essentially), but changing it to ~= from >= doesn't change that procedure, and we pretty much always want to pin it to the most recent version.

If it is pinned on main, then there is nothing special to do for release, and just the repinning to newer versions doesn't get backported.

@tacaswell
Copy link
Member

fair point. I am in general against hard pins, but this is in an internal requirements file we use for setting up CI + developers machines (not something carved into stone on pypi or a packaging system) so I guess that would be OK.

@QuLogic QuLogic merged commit ddd817f into matplotlib:v3.7.x Mar 1, 2023
@QuLogic QuLogic deleted the pin-theme branch March 1, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: build building the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants