Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin sphinx themes more strictly #25369

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Mar 2, 2023

PR Summary

As discussed on the call today.

PR Checklist

Documentation and Tests

  • [n/a] Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • [n/a] New plotting related features are documented with examples.

Release Notes

  • [n/a] New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • [n/a] API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • [n/a] Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@QuLogic QuLogic added the Build label Mar 2, 2023
@QuLogic QuLogic added this to the v3.7.1 milestone Mar 2, 2023
@QuLogic
Copy link
Member Author

QuLogic commented Mar 2, 2023

Actually, I know this is going to conflict with v3.7.x due to #25307, so I'll just do the backport myself manually after merging, and not bother meeseeksdev with it.

@QuLogic QuLogic modified the milestones: v3.7.1, v3.8.0 Mar 2, 2023
@@ -13,8 +13,8 @@ ipython
ipywidgets
numpydoc>=1.0
packaging>=20
pydata-sphinx-theme>=0.12.0
mpl-sphinx-theme>=3.7.0
pydata-sphinx-theme~=0.12.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add to environment.yml as well...

@jklymak jklymak merged commit 447c0c8 into matplotlib:main Mar 2, 2023
@QuLogic QuLogic deleted the pin-sphinx branch March 2, 2023 21:35
@QuLogic QuLogic modified the milestones: v3.8.0, v3.7.1 Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants