MAINT: dviread refactoring #5177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Available in Python 2.6 and up.
so files get closed automatically Available in Python 2.5 and up
This should exercise the most important parts.
Replace the massive if-elif block with a list of functions indexed by opcode. Use a decorator (new in Python 2.4) to register the functions in the dispatch table and to factor out the repeated checks for correct parser state and argument reading.
Hide the dispatch table from sphinx, and improve the docstring for Dvi.
|
Definite improvement. Nice to have some lower-level unit tests on this stuff, too. Are there any |
|
I don't think there are usetex tests in lib/matplotlib/tests except for some for the PS backend. |
|
@jkseppan We build the examples as part of the automatic docs build but there is no verification of output so they only act as smoke tests |
This passes on the current master as well as this branch. For whatever reason, the svg backend has trouble rendering the test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use some more modern Python idioms such as context managers and named tuples. Replace the big if-elif block with a table of function objects, adding a little bit of complexity in the form of a decorator but removing a lot of repeated code along with the elifs. Make the code PEP8 compliant.