use locale.getpreferredencoding()
to prevent OS X locale issues
#5931
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue on OS X when the locale is set to
UTF-8
(no language), which happens out of the box on some systems. This has been reported before in #3870 and #5481. Such a locale cannot be parsed by Python'slocale.getdefaultlocale()
, which will throwwhen importing matplotlib.
Python issue 18378 deals with this matter. There you will find the suggestion that a project should use
locale.getpreferredencoding()
overlocale.getdefaultlocale()[1]
, which coincidentally also fixes the issue on OS X. The PR implements this change.