BF: protect against locale in sphinext text #6601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sphinxext tests were loading a text file with encoding not stated, making the test sensitive to the default locale of the testing machine. See: https://travis-ci.org/matthew-brett/matplotlib-wheels/jobs/138518917#L8787 Read the text file as binary to avoid need for encoding.
|
This should probably be backported? |
tacaswell
added a commit
that referenced
this pull request
Jul 10, 2016
BF: protect against locale in sphinext text Conflicts: lib/matplotlib/sphinxext/tests/test_tinypages.py backport minimal changes
|
(finally) Backported to v2.x as 76fd818 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sphinxext tests were loading a text file with encoding not stated,
making the test sensitive to the default locale of the testing machine.
See:
https://travis-ci.org/matthew-brett/matplotlib-wheels/jobs/138518917#L8787
Read the text file as binary to avoid need for encoding.