Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash if byte-compiled level 2 #6719

Closed
wants to merge 5 commits into from
Closed

Fix crash if byte-compiled level 2 #6719

wants to merge 5 commits into from

Conversation

JGoutin
Copy link
Contributor

@JGoutin JGoutin commented Jul 10, 2016

Fix crash if byte-compiled level 2 (Python -OO command line argument)

Fix crash if byte-compiled level 2 (Python -OO command line argument)
@tacaswell
Copy link
Member

Is this really the only place that breaks? We have some pretty extensive docstring substitution/rewriting code.

@JGoutin
Copy link
Contributor Author

JGoutin commented Jul 10, 2016

After fixing this, I get no more crash on importing Matplotlib. But, I don't use all Matplotlib possibilities in my software and don't import everything.

The bug come only when __doc__ ( = None if byte compiled level 2) is used with a str function or operator.

@jenshnielsen
Copy link
Member

I guess if we want to ensure that this works one of the jobs on travis should run the tests with -OO ?

@tacaswell
Copy link
Member

Indeed, I nominate the 3.4 run (2.7 has the old deps, 3.5 has pandas, and the nightly is an optional fail).

@tacaswell tacaswell added this to the 2.1 (next point release) milestone Jul 11, 2016
@JGoutin
Copy link
Contributor Author

JGoutin commented Jul 12, 2016

Tried to update .travis.yml to include test with -OO. But failed before test.

@tacaswell
Copy link
Member

This seems to need a rebase?

@JGoutin
Copy link
Contributor Author

JGoutin commented Jul 12, 2016

Go to #6729

@JGoutin JGoutin closed this Jul 12, 2016
@JGoutin JGoutin deleted the mplot3d-axes3d-patch branch July 12, 2016 17:35
@QuLogic QuLogic modified the milestones: unassigned, 2.1 (next point release) Jul 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants