-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ternary #6737
Ternary #6737
Conversation
…ternary Conflicts: lib/matplotlib/projections/__init__.py
Looking at the AppVeyor failures, I do not see how they relate to this PR. Is this a known (general) failure? Looking at the COVERALL failures, I'll have to check, but this might be due to changes in the code preceding my modification. Is this something we should really worry about? If so, I'll try and see what precisely has to be done to redress the situation. |
Just ignore coveralls it seems to be flaky. But that being said if we are going to merge this in will need good test coverage of the Ternary module. The failures on AppVeyor are probably not related. |
closing and reopening to see if the changes in master regarding the miktex failure lets this pass. |
There is a pretty robust community that uses Ternary diagrams. How many of them use matplotlib is another issue. But this would be a nice addition at some point. My quick look at it is that the interface still needs some work, and that the demo should definitely not be in |
@jklymak I work with enough geochemists to know that this would be a great addition. Perhaps this should get it's own mini-package, e.g., |
I agree that this would be better suited as a third party package. |
Closing then - this PR will still turn up in a google search and someone can base their code on it. If someone wants to open as an issue, then great! |
Hi Sorry for replying late. Kevin Davies developed the code Ligon and I afterwards updated. I had also independently developed the same kind of functionality for work (meteorology - a very long time ago this started as MATLAB code), and updated it for my personal research (math - see for instance https://arxiv.org/abs/1610.02295). The original idea was that perhaps Kevin's code and mine would be merged, but this did not happen (lack of time, on my part, sorry). As I understand, the preferred solution would be to pull the code from matplotlib and put into an independent package. I have no objection to that, but would like to know what Kevin and Ligon feel about it. As well, which code base should be used? What interface adjustments would be wanted? I can (probably) work on this this summer (after I document and release an entirely different python library in the next few days, and an also completely different C++ library a little later on). Perhaps a new thread would be useful. Any comment welcome! |
@jklymak What is the recommended package for ternary plots? |
I don't make ternary plots so your google search would be as good as mine. If you find a good one, encourage them to submit to https://matplotlib.org/mpl-third-party/ |
This one looks like it's the most recently updated https://github.com/yu9824/ternary_diagram |
Paris (U.E.), le 24/09/2022
Hi
Some six years or so ago, I had submitted a matplotlib package to create ternary diagrams that I had developed for work I was doing at the time. Another package was made by Kevin Devies or Ian Thomas, and the aim, at the time was to unify them. However it was later decided that it would be better if that package were not integrated into the matplotlib distribution, but given as a third party package. Sadly, I never had the time to do the work which was needed at the time, and as well did not need to use ternary diagrams for subsequent work, so the project died slowly. At least the package you found still exists and seems to be usable (I have not tried this), though the tradeoffs look different from the older packages (this one relies on more packages than mine, for instance, but the older packages had a utility layer written in C++ to accelerate things, which this one seems not to have).
If there is some interest, and I finally have some time, I might try to revive this, but it might take quite some time to do, if only to remember what had to be done, so, in the meantime, it would certainly be best to go with what works now.
Best of luck
Hubert Holin
… On 23 Sep 2022, at 18:03, hannah ***@***.***> wrote:
This one looks like it's the most recently updated https://github.com/yu9824/ternary_diagram <https://github.com/yu9824/ternary_diagram>
—
Reply to this email directly, view it on GitHub <#6737 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIG7DD3VMNWF7OBCXO2LBTV7XIFDANCNFSM4CJSNFVA>.
You are receiving this because you authored the thread.
|
Hubert, all, |
This update should (git permitting…) resolve the failures referenced as
https://travis-ci.org/matplotlib/matplotlib/jobs/41735175
and as discussed in #3828 .