Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ternary #6737

Closed
wants to merge 18 commits into from
Closed

Ternary #6737

wants to merge 18 commits into from

Conversation

HubertHolin
Copy link
Contributor

This update should (git permitting…) resolve the failures referenced as

https://travis-ci.org/matplotlib/matplotlib/jobs/41735175

and as discussed in #3828 .

@HubertHolin
Copy link
Contributor Author

Looking at the AppVeyor failures, I do not see how they relate to this PR. Is this a known (general) failure?

Looking at the COVERALL failures, I'll have to check, but this might be due to changes in the code preceding my modification. Is this something we should really worry about? If so, I'll try and see what precisely has to be done to redress the situation.

@jenshnielsen
Copy link
Member

Just ignore coveralls it seems to be flaky. But that being said if we are going to merge this in will need good test coverage of the Ternary module.

The failures on AppVeyor are probably not related.

@jankatins
Copy link
Contributor

closing and reopening to see if the changes in master regarding the miktex failure lets this pass.

@jankatins jankatins closed this Jul 15, 2016
@jankatins jankatins reopened this Jul 15, 2016
@tacaswell tacaswell modified the milestone: 2.1 (next point release) Jul 16, 2016
@petehuang petehuang mentioned this pull request Dec 30, 2016
@tacaswell tacaswell modified the milestones: 2.1 (next point release), 2.2 (next next feature release) Aug 29, 2017
@jklymak jklymak modified the milestones: needs sorting, v3.0 May 9, 2018
@jklymak
Copy link
Member

jklymak commented May 9, 2018

There is a pretty robust community that uses Ternary diagrams. How many of them use matplotlib is another issue. But this would be a nice addition at some point. My quick look at it is that the interface still needs some work, and that the demo should definitely not be in pylab 😉

@jklymak jklymak added the Good first issue Open a pull request against these issues if there are no active ones! label May 9, 2018
@phobson
Copy link
Member

phobson commented May 10, 2018

@jklymak I work with enough geochemists to know that this would be a great addition.

Perhaps this should get it's own mini-package, e.g., mpl-ternary

@anntzer
Copy link
Contributor

anntzer commented May 10, 2018

I agree that this would be better suited as a third party package.

@jklymak
Copy link
Member

jklymak commented May 10, 2018

Closing then - this PR will still turn up in a google search and someone can base their code on it. If someone wants to open as an issue, then great!

@jklymak jklymak closed this May 10, 2018
@HubertHolin
Copy link
Contributor Author

Hi

Sorry for replying late. Kevin Davies developed the code Ligon and I afterwards updated. I had also independently developed the same kind of functionality for work (meteorology - a very long time ago this started as MATLAB code), and updated it for my personal research (math - see for instance https://arxiv.org/abs/1610.02295). The original idea was that perhaps Kevin's code and mine would be merged, but this did not happen (lack of time, on my part, sorry). As I understand, the preferred solution would be to pull the code from matplotlib and put into an independent package. I have no objection to that, but would like to know what Kevin and Ligon feel about it. As well, which code base should be used? What interface adjustments would be wanted? I can (probably) work on this this summer (after I document and release an entirely different python library in the next few days, and an also completely different C++ library a little later on).

Perhaps a new thread would be useful. Any comment welcome!

@anntzer anntzer mentioned this pull request Mar 2, 2019
@carlosgmartin
Copy link

@jklymak What is the recommended package for ternary plots?

@jklymak
Copy link
Member

jklymak commented Sep 23, 2022

I don't make ternary plots so your google search would be as good as mine. If you find a good one, encourage them to submit to https://matplotlib.org/mpl-third-party/

@story645
Copy link
Member

This one looks like it's the most recently updated https://github.com/yu9824/ternary_diagram

@HubertHolin
Copy link
Contributor Author

HubertHolin commented Sep 23, 2022 via email

@kdavies4
Copy link
Contributor

kdavies4 commented Sep 24, 2022

Hubert, all,
It's good to hear about this, and I endorse taking this however the team decides is best. I contributed my part to ternary plots as a general fascination and use in visualizing some work for my PhD, but since then, well life gets busy, and I still don't think I have the resources to actively participate. As I recall, what I did was somewhat of a hack of layering and transforming existing axes in matplotlib, and a "cleaner" approach would have required some fundamental changes or additions to the existing matplotlib axes or a new class entirely which could have been rather disruptive. I guess that's where the suggestion came for a third party package. Regardless, my point is that if there is interest and opportunity to revive this, I say by all means please go ahead.
Best regards,
Kevin (from Honolulu, HI USA)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Open a pull request against these issues if there are no active ones! New feature status: needs rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.