Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify to_rgba docstring. #7548

Merged
merged 1 commit into from
Dec 4, 2016

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 1, 2016

All's in the title.

Copy link
Member

@NelleV NelleV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with merging it as is, but it'd be nicer if it was numpydoc format. Do you mind if I do the change and push to your repository?

@anntzer
Copy link
Contributor Author

anntzer commented Dec 2, 2016

Go ahead.

@anntzer
Copy link
Contributor Author

anntzer commented Dec 2, 2016

(And you can force-push as much as you want.)

@codecov-io
Copy link

codecov-io commented Dec 2, 2016

Current coverage is 61.89% (diff: 100%)

Merging #7548 into master will increase coverage by <.01%

@@             master      #7548   diff @@
==========================================
  Files           173        173          
  Lines         56140      56172    +32   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          34743      34767    +24   
- Misses        21397      21405     +8   
  Partials          0          0          

Powered by Codecov. Last update 45e4a46...6d0ee3f

@tacaswell
Copy link
Member

@NelleV going to merge this as-is (as I want it for the rc), can you follow up with another PR for the formatting?

@tacaswell tacaswell merged commit 2ce3b61 into matplotlib:master Dec 4, 2016
@anntzer anntzer deleted the clarify-to_rgba-docstring branch December 4, 2016 21:57
@anntzer
Copy link
Contributor Author

anntzer commented Dec 4, 2016

Sure.
Edit: @NelleV still gets to do it :)

tacaswell added a commit that referenced this pull request Dec 4, 2016
@tacaswell
Copy link
Member

backported to v2.x as 56635c5

@QuLogic QuLogic added this to the 2.0 (style change major release) milestone Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants