Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix streamplot for non-square grids. #789

Merged
merged 1 commit into from
Apr 16, 2012

Conversation

tonysyu
Copy link
Contributor

@tonysyu tonysyu commented Mar 22, 2012

  • Order of x/y was switched.
  • Additional cleanup (remove unused import and old comment, improve docstring).

* Order of x/y was switched.
* Additional cleanup (remove unused import and old comment, improve docstring).
@jswhit
Copy link
Contributor

jswhit commented Mar 26, 2012

I just noticed that the patches for the arrows on the streamlines are not returned - so you can't remove them from the axes instance or alter their properties. Perhaps a streamline collection object could be created (and returned) that includes both the streamline line collection and the arrow patch collection.

@tonysyu
Copy link
Contributor Author

tonysyu commented Mar 28, 2012

@jswhit Yeah, the plan was to add this at some point, but it fell off my radar. Thanks for the reminder I just submitted a PR (#803) to return an arrow patch collection. I think creating a custom streamline collection object is a bit too much (work); instead, I just return separate collections for the streamlines and arrow patches.

efiring added a commit that referenced this pull request Apr 16, 2012
Fix streamplot for non-square grids.
@efiring efiring merged commit e7ca3a3 into matplotlib:master Apr 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants