Fix check for DISPLAY on PyQt5. #8149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check avoids a fatal error when the DISPLAY environment variable is not set using PyQt5, e.g. ``` MPLBACKEND=qt5agg DISPLAY= python -c 'from pylab import *; plot(); show()' ``` (The previous check only worked on PyQt4.)
|
This goes from hard crash to |
|
It makes the behavior consistent across the Qt4 and Qt5 backends. See #1905 for the original motivation. |
QuLogic
approved these changes
Feb 28, 2017
anntzer
changed the title
QuLogic
changed the title
QuLogic
changed the title
QuLogic
pushed a commit
to QuLogic/matplotlib
that referenced
this pull request
Mar 27, 2017
Fix check for DISPLAY on PyQt5.
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check avoids a fatal error when the DISPLAY environment variable is
not set using PyQt5, e.g.
(The previous check only worked on PyQt4.)