-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge fill_demo and fill_demo_features #8154
Conversation
@@ -1,13 +1,13 @@ | |||
import numpy as np | |||
import matplotlib.pyplot as plt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could the import lines be just below the title (as in the original file)? Otherwise this looks good if the tests pass!
@@ -16,3 +16,22 @@ | |||
ax.fill(x, y, zorder=10) | |||
ax.grid(True, zorder=5) | |||
plt.show() | |||
|
|||
""" | |||
======================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to merge these two docstrings into something coherent at the beginning of the file. Just smooshing the separate files together is no good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review.
I was kinda sleepy, messed up commit message XD
@@ -16,3 +16,22 @@ | |||
ax.fill(x, y, zorder=10) | |||
ax.grid(True, zorder=5) | |||
plt.show() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove; there's one at the end.
Thanks @patniharshit ! |
refs #7956