merge fill_demo and fill_demo_features #8154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
requested changes
Feb 26, 2017
| @@ -1,13 +1,13 @@ | |||
| import numpy as np | |||
| import matplotlib.pyplot as plt | |||
There was a problem hiding this comment.
Could the import lines be just below the title (as in the original file)? Otherwise this looks good if the tests pass!
dstansby
approved these changes
Feb 26, 2017
dstansby
changed the title
QuLogic
requested changes
Feb 26, 2017
| @@ -16,3 +16,22 @@ | |||
| ax.fill(x, y, zorder=10) | |||
| ax.grid(True, zorder=5) | |||
| plt.show() | |||
|
|
|||
| """ | |||
| ======================== | |||
There was a problem hiding this comment.
You need to merge these two docstrings into something coherent at the beginning of the file. Just smooshing the separate files together is no good.
There was a problem hiding this comment.
Please review.
I was kinda sleepy, messed up commit message XD
| @@ -16,3 +16,22 @@ | |||
| ax.fill(x, y, zorder=10) | |||
| ax.grid(True, zorder=5) | |||
| plt.show() | |||
There was a problem hiding this comment.
Remove; there's one at the end.
|
Thanks @patniharshit ! |
QuLogic
modified the milestones:
2.1 (next point release),
2.0.1 (next bug fix release)
QuLogic
changed the title
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #7956