Clean up flake8 and yamllint issues #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There appears to be no need to write `all.yml` as nothing outside the build script uses it. The effect of using it is to re-order items and flatten the outer dictionary into list. But we can just do all that work when reading, and the sorting in the template.
We only need to be in the context manager for the file reading.
And add a minimal config setting line length to 88 as in Matplotlib.
This seems redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
For consistency with Matplotlib, I added a config to set line length to 88 in both Python and YAML files.
I also went through the YAML files and added a period at the end of the description, fixed the keyword entries that were strings instead of lists, and ran codespell.
This is based on #149.