Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificate errors give a 404 link #29

Open
richvdh opened this issue Sep 23, 2021 · 2 comments
Open

Certificate errors give a 404 link #29

richvdh opened this issue Sep 23, 2021 · 2 comments

Comments

@richvdh
Copy link
Member

richvdh commented Sep 23, 2021

If there is a certificate error (particularly if you have a SRV record and a cert for the wrong domain), the UI links to https://github.com/matrix-org/synapse/blob/master/docs/MSC1711_certificates_FAQ.md#configuring-certificates-for-compatibility-with-synapse-100:

image

While that document is still technically correct, it's written from the perspective of people upgrading from Synapse 0.99 to Synapse 1.00, so isn't terribly helpful. 2023/01/16: it's now a 404.

Probably we should just link to https://matrix-org.github.io/synapse/latest/delegate.html. We might also want to add a small note about the gotcha under https://matrix-org.github.io/synapse/latest/delegate.html#srv-dns-record-delegation - "note in particular that you must present a certificate for the original server_name".

@babolivier
Copy link
Contributor

Some additional info, the code for this warning is located here:

fed-tester-ui/app.js

Lines 74 to 80 in e51e89c

if (!report.Checks.ValidCertificates) {
tldr.push(<div className="warning" key={`cert-${tldr.length}`}>
WARN: Could not find a valid certificate for {ip}.
See <a href="https://github.com/matrix-org/synapse/blob/master/docs/MSC1711_certificates_FAQ.md#configuring-certificates-for-compatibility-with-synapse-100">this
documentation</a> for instructions on how to fix this.
</div>)
}

@richvdh
Copy link
Member Author

richvdh commented Feb 4, 2022

doubly important now that matrix-org/synapse#11907 has landed, making the link a 404

@richvdh richvdh changed the title Certificate errors give an unhelpful link to outdated MSC1711 docs Certificate errors give a 404 link Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants