Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s2s: spec how to leave a room over federation #1401

Closed
turt2live opened this issue Jul 10, 2018 · 0 comments
Closed

s2s: spec how to leave a room over federation #1401

turt2live opened this issue Jul 10, 2018 · 0 comments
Assignees
@turt2live
Labels
s2s Server-to-Server API (federation) spec-omission implemented but not currently specified

Comments

@turt2live
Copy link
Member

https://github.com/matrix-org/dendrite/pull/535/files
@turt2live turt2live added spec-omission implemented but not currently specified s2s Server-to-Server API (federation) labels Jul 10, 2018
@turt2live turt2live self-assigned this Jul 20, 2018
turt2live added a commit to turt2live/matrix-doc that referenced this issue Jul 26, 2018
@turt2live
Document how leaving rooms/rejecting invites over federation works
9fdd8a6 
Fixes matrix-org#1401

This is very similar to the joining rooms handshake, and much of it is a near copy/paste of the make_join and send_join API. The major difference is the send_leave API doesn't return anything.

References:
* Handling of make_leave: https://github.com/matrix-org/synapse/blob/d69decd5c78c72abef50b597a689e2bc55a39702/synapse/handlers/federation.py#L1285-L1310
* send_leave route: https://github.com/matrix-org/synapse/blob/d69decd5c78c72abef50b597a689e2bc55a39702/synapse/federation/transport/client.py#L267
* make_leave route: https://github.com/matrix-org/synapse/blob/d69decd5c78c72abef50b597a689e2bc55a39702/synapse/federation/transport/server.py#L396
* send_leave returning nothing: https://github.com/matrix-org/synapse/blob/d69decd5c78c72abef50b597a689e2bc55a39702/synapse/handlers/federation.py#L1346
This was referenced Jul 26, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
s2s Server-to-Server API (federation) spec-omission implemented but not currently specified
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@turt2live