Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homeserver resource limiting error codes #1504

Closed
neilisfragile opened this issue Aug 13, 2018 · 5 comments
Closed

Homeserver resource limiting error codes #1504

neilisfragile opened this issue Aug 13, 2018 · 5 comments
Assignees
Labels
kind:feature MSC for not-core and not-maintenance stuff merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal

Comments

@neilisfragile
Copy link
Contributor

Documentation: https://docs.google.com/document/d/1_CgwkfLznU56fwLUFZXFnKivzVUPjjNsTO0DpCB9ncM/edit?usp=sharing

Encompasses #1470 (since M_SOFT_LIMIT_EXCEEDED covers M_MAU_LIMIT_EXCEEDED)

@neilisfragile neilisfragile added proposal-ready-for-review proposal A matrix spec change proposal labels Aug 13, 2018
@turt2live
Copy link
Member

How does M_SOFT_LIMIT_EXCEEDED cover M_MAU_LIMIT_EXCEEDED? Was the MAU error replaced?

It'd be nice to have the use case for having two different errors documented. A client doesn't appear to have instructions on what to do when a subset of users are disallowed versus all of them - it seems like it should only care if the requesting user is limited for some reason.

@neilisfragile
Copy link
Contributor Author

How does M_SOFT_LIMIT_EXCEEDED cover M_MAU_LIMIT_EXCEEDED? Was the MAU error replaced?Yes

It seems like it should only care if the requesting user is limited for some reason. I'd see it as more for the users benefit - they know they can't access the service but that the rest of the service is not down.

If it is not much use from a client perspective - then I'm not overly attached to it

@turt2live
Copy link
Member

I think a single error code would be okay, given the user would (hopefully) be made aware of what's going on through other channels, such as the server notices room. Would love to hear from some client authors though, like @KitsuneRal and @mujx, as well as the wider client dev community.

@richvdh
Copy link
Member

richvdh commented Feb 7, 2019

I think this has been implemented without ever having completed review, or indeed ever being written up into a coherent document 😠

I guess it needs speccing now

@richvdh richvdh added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed proposal-in-review labels Feb 7, 2019
@turt2live turt2live self-assigned this Feb 11, 2019
turt2live added a commit that referenced this issue Feb 11, 2019
Original proposal: #1504

No changes from the original proposal or implementations have been made intentionally here.
@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review merged A proposal whose PR has merged into the spec! and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Feb 11, 2019
@turt2live
Copy link
Member

Merged via #1874

@turt2live turt2live added the kind:feature MSC for not-core and not-maintenance stuff label Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feature MSC for not-core and not-maintenance stuff merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
None yet
Development

No branches or pull requests

4 participants