Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected phone number format not well-specified #1982

Closed
joepie91 opened this issue Apr 30, 2019 · 2 comments · Fixed by #2342
Closed

Expected phone number format not well-specified #1982

joepie91 opened this issue Apr 30, 2019 · 2 comments · Fixed by #2342
Assignees
Labels
clarification An area where the spec could do with being more explicit client-server Client-Server API

Comments

@joepie91
Copy link

joepie91 commented Apr 30, 2019

From here:

"identifier": {
  "type": "m.id.phone",
  "country": "<The country that the phone number is from>",
  "phone": "<The phone number>"
}

The specification does not define exactly what format the country field should have - should it be a country calling code, an ISO-3166 country code, or something else entirely?

It also doesn't specify what format the phone field should have, although I assume that it's expecting the phone number formatted as a local number.

Edit: To be clear, this is not about third-party identifiers with the msisdn medium, but about m.id.phone-type user identifiers.

@turt2live turt2live added clarification An area where the spec could do with being more explicit client-server Client-Server API labels Apr 30, 2019
@uhoreg
Copy link
Member

uhoreg commented Apr 30, 2019

From the Riot code, it looks like it's ISO-3166-1 alpha-2 code. @dbkr can you confirm?

@turt2live
Copy link
Member

ISO-3166-1 alpha-2 code looks right to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification An area where the spec could do with being more explicit client-server Client-Server API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants