Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec permits server names to be empty #2460

Closed
joepie91 opened this issue Mar 15, 2020 · 0 comments · Fixed by #2576
Closed

Spec permits server names to be empty #2460

joepie91 opened this issue Mar 15, 2020 · 0 comments · Fixed by #2576
Assignees
@turt2live
Labels
clarification An area where the spec could do with being more explicit

Comments

@joepie91
Copy link

Per the server name spec:

server_name = hostname [ ":" port ]
[...]
hostname    = IPv4address / "[" IPv6address "]" / dns-name
[...]
dns-name    = *255dns-char

Presumably, this permits zero to 255 characters (as the lower boundary is not specified, unlike for IPv4address), and so an empty server name would be valid according to this spec, as it is zero dns-chars.

This should probably be dns-name = 1*255dns-char instead?
@turt2live turt2live added the clarification An area where the spec could do with being more explicit label Mar 15, 2020
turt2live added a commit that referenced this issue May 25, 2020
@turt2live
Clarify that server names are at least 1 character
e9998c5 
Fixes #2460
@turt2live turt2live self-assigned this May 25, 2020
@turt2live turt2live mentioned this issue May 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
clarification An area where the spec could do with being more explicit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify that server names are at least 1 character matrix-org/matrix-spec-proposals
2 participants
@turt2live @joepie91