Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unspec'd server_name request param for /join/{roomIdOrAlias} #904

Closed
pik opened this issue May 1, 2017 · 5 comments
Closed

Unspec'd server_name request param for /join/{roomIdOrAlias} #904

pik opened this issue May 1, 2017 · 5 comments
Assignees
Labels
spec-omission implemented but not currently specified

Comments

@pik
Copy link

pik commented May 1, 2017

ref: matrix-org/synapse#2171

Currently in order to join a room on a different (non-HS) server by roomId a server_name requestParam should be provided, this behavior is not documented. Also there are some clarifying points that I'm not sure about, for example the current synapse endpoint accepts remote_host_names non-singular (what is the significance of joining the same room on multiple servers, is this even possible ? ). If the answer to the later that joining a room by room_id is always / only a singular action than possibly Synapse should be extracting server_name from the <opaque_id>:<server_name> combo and deprecate the arg in requestParams.

@richvdh
Copy link
Member

richvdh commented May 2, 2017

@kegsay apparently you added this in matrix-org/synapse#794; was the intention that it become part of the spec? do you know if there is already a bug to track it?

@kegsay
Copy link
Member

kegsay commented May 2, 2017

There isn't a bug to track it. It seems like a useful thing to have, and it was originally added to aid Go-NEB development which originally was going to be hosted on a different HS.

It's a solution to the problem of "I have a room ID, I know that I can join it via server X because I was told out-of-band, so please just try."

@richvdh richvdh added the spec-omission implemented but not currently specified label Jul 5, 2017
@t3chguy
Copy link
Member

t3chguy commented Jul 26, 2017

ooi why doesn't it go on the room-id specific endpoint (http://matrix.org/speculator/spec/HEAD/client_server/unstable.html#post-matrix-client-unstable-rooms-roomid-join) also, should probably be generalised to serverName to match casing of other query params.

Link to self

@ghost
Copy link

ghost commented Aug 7, 2018

@turt2live Does d279fda mean that the extra homeserver parameter is now part of the spec-to-be?

@turt2live
Copy link
Member

Yup! It's currently sitting in unstable, scheduled for r0.4.0 by the end of the month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-omission implemented but not currently specified
Projects
None yet
Development

No branches or pull requests

5 participants