MSC2998: Room Version 7 #2998

anoadragon453 · 2021-02-08T11:44:31Z

tulir · 2021-02-08T11:53:53Z

proposals/2998-rooms-v7.md

+A new room version, `7`, is proposed using [room version 6](https://matrix.org/docs/spec/rooms/v6.html) as a base
+and incorporating the following MSCs:
+
+* [MSC2174](https://github.com/matrix-org/matrix-doc/pull/2174) - Move the `redacts` key to a sane place.


There's no point in having two migrations of redaction format, we should just skip this step and go straight for mass redactions

@tulir I didn't include Mass Redactions as it doesn't currently have an implementation.

You're right in that putting MSC2244 and MSC2174, especially as the former builds on the latter, into the same room version makes sense though. I'd be happy to review/help with a Synapse PR for it.

also, doesn't content.redacts have to be protected from redaction now?

It is protected from redaction by MSC2176, that part works the same way for MSC2174 and MSC2244.

proposals/2998-rooms-v7.md

Co-authored-by: Travis Ralston <travpc@gmail.com>

anoadragon453 · 2021-02-18T15:59:22Z

It turns out MSC2175 (remove the creator field from create events) and MSC2174 (move the redacts key) do not have an implementation yet after all, so they will also be excluded. MSC2176 (update redacted event fields) does have an implementation however, and while related to redactions, is only concerned about the keys removed from an event by the server when an event is redacted. This does not affect the structure of a redaction event, like MSC2174 and MSC2244 (mass redactions) is concerned with.

While this leaves us with a fairly lean room version, releasing new features and changes more regularly in smaller room versions is a good precedence to set.

clokep · 2021-02-18T16:13:55Z

It turns out MSC2175 (remove the creator field from create events) and MSC2174 (move the redacts key) do not have an implementation yet after all, so they will also be excluded. MSC2176 (update redacted event fields) does have an implementation however, and while related to redactions, is only concerned about the keys removed from an event by the server when an event is redacted.

I'm not sure I fully grok what this is saying, but #2176 seems to imply it only makes sense if #2174 was also implemented?

anoadragon453 · 2021-02-22T19:13:12Z

MSC2174, MSC2176 and MSC2274 do indeed rely on each other and it would be best to land all of those in a single room version. As the implementation for each are not yet ready, as well as lacking an implementation for MSC2175 we're going to leave them til the next room version, and just go ahead with knocking for this one.

Note that this MSC has been updated to simply reserve v7 for knocking. It does not prevent an MSC for room v8+ appearing in parallel once the above MSCs (or any other MSCs for that matter) have implementations ready.

Given the above, I'm going to propose FCP on this one to get the rest of the team's feedback.

@mscbot fcp merge

mscbot · 2021-02-22T19:13:14Z

Team member @anoadragon453 has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

dbkr · 2021-02-24T15:02:51Z

proposals/2998-rooms-v7.md

+* [MSC2403](https://github.com/matrix-org/matrix-doc/pull/2403) - Add "knock" feature.
+
+Though other MSCs are capable of being included in this version, they do not have sufficient implementation to be
+considered stable enough for v7 rooms. A future room version may still include them.


This took me about 5 reads to understand - isn't it just saying, "other mscs aren't ready yet because they don't have impls"?

Indeed, but written a bit tersely for the spec. I'm open to suggestions for something slightly clearer though.

Maybe Though other MSCs could be included in this version, they do not have satisfactory implementations...?

I've dropped the stable enough bit. Hopefully that makes things slightly clearer.

mscbot · 2021-02-24T15:09:21Z

🔔 This is now entering its final comment period, as per the review above. 🔔

mscbot · 2021-03-01T15:09:32Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

Spec for #2998 Spec for #2403 This deliberately does not help towards fixing #3153 in order to remain consistent with prior room versions, and to keep the diff smaller on this change. A future change will address room version legibility.

turt2live · 2021-04-30T15:22:13Z

merged 🎉

MSC2998: Room Version 7

Spec for #2998 Spec for #2403 This deliberately does not help towards fixing #3153 in order to remain consistent with prior room versions, and to keep the diff smaller on this change. A future change will address room version legibility.

MSC2998: Room Version 7

Spec for #2998 Spec for #2403 This deliberately does not help towards fixing #3153 in order to remain consistent with prior room versions, and to keep the diff smaller on this change. A future change will address room version legibility.

anoadragon453 changed the title ~~MSCXXXX: Room Version 7~~ MSC2998: Room Version 7 Feb 8, 2021

anoadragon453 added kind:core MSC which is critical to the protocol's success proposal A matrix spec change proposal labels Feb 8, 2021

anoadragon453 added 2 commits February 8, 2021 11:50

Define room version 7

3735def

MSC2998

1f07f0d

anoadragon453 force-pushed the anoa/room_version_7 branch from d6d1784 to 1f07f0d Compare February 8, 2021 11:51

tulir requested changes Feb 8, 2021

View reviewed changes

turt2live added the proposal-in-review label Feb 8, 2021

turt2live reviewed Feb 8, 2021

View reviewed changes

proposals/2998-rooms-v7.md Outdated Show resolved Hide resolved

turt2live self-requested a review February 8, 2021 18:01

anoadragon453 and others added 2 commits February 8, 2021 18:04

v6 -> v7

336e5a2

Co-authored-by: Travis Ralston <travpc@gmail.com>

Remove MSC2175, MSC2174 due to lack of implementation

97109d4

Alter to reserve v7 instead of declare v7

fadee27

mscbot added disposition-merge proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. and removed proposal-in-review labels Feb 22, 2021

turt2live removed their request for review February 22, 2021 19:14

dbkr reviewed Feb 24, 2021

View reviewed changes

mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Feb 24, 2021

Clarify prose

2acc0a6

mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Mar 1, 2021

turt2live merged commit 09e5015 into master Mar 1, 2021

This was referenced Mar 18, 2021

Change knocking room version to v7 matrix-org/synapse-dinsic#88

Merged

Switch Complement branch back to master matrix-org/synapse-dinsic#91

Open

turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Apr 6, 2021

turt2live self-assigned this Apr 28, 2021

turt2live mentioned this pull request Apr 29, 2021

Add knocking to the spec #3154

Merged

richvdh pushed a commit that referenced this pull request Aug 23, 2021

Merge pull request #2998 from matrix-org/anoa/room_version_7

aec5d28

MSC2998: Room Version 7

richvdh pushed a commit that referenced this pull request Aug 27, 2021

Merge pull request #2998 from matrix-org/anoa/room_version_7

b139312

MSC2998: Room Version 7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MSC2998: Room Version 7 #2998

MSC2998: Room Version 7 #2998

anoadragon453 commented Feb 8, 2021 •

edited

Loading

tulir Feb 8, 2021

anoadragon453 Feb 8, 2021

Sorunome Feb 8, 2021

tulir Feb 8, 2021

anoadragon453 commented Feb 18, 2021

clokep commented Feb 18, 2021

anoadragon453 commented Feb 22, 2021

mscbot commented Feb 22, 2021 •

edited by dbkr

Loading

dbkr Feb 24, 2021 •

edited

Loading

anoadragon453 Feb 24, 2021

gary-kim Feb 24, 2021

anoadragon453 Feb 25, 2021

mscbot commented Feb 24, 2021

mscbot commented Mar 1, 2021

turt2live commented Apr 30, 2021

MSC2998: Room Version 7 #2998

MSC2998: Room Version 7 #2998

Conversation

anoadragon453 commented Feb 8, 2021 • edited Loading

tulir Feb 8, 2021

Choose a reason for hiding this comment

anoadragon453 Feb 8, 2021

Choose a reason for hiding this comment

Sorunome Feb 8, 2021

Choose a reason for hiding this comment

tulir Feb 8, 2021

Choose a reason for hiding this comment

anoadragon453 commented Feb 18, 2021

clokep commented Feb 18, 2021

anoadragon453 commented Feb 22, 2021

mscbot commented Feb 22, 2021 • edited by dbkr Loading

dbkr Feb 24, 2021 • edited Loading

Choose a reason for hiding this comment

anoadragon453 Feb 24, 2021

Choose a reason for hiding this comment

gary-kim Feb 24, 2021

Choose a reason for hiding this comment

anoadragon453 Feb 25, 2021

Choose a reason for hiding this comment

mscbot commented Feb 24, 2021

mscbot commented Mar 1, 2021

turt2live commented Apr 30, 2021

anoadragon453 commented Feb 8, 2021 •

edited

Loading

mscbot commented Feb 22, 2021 •

edited by dbkr

Loading

dbkr Feb 24, 2021 •

edited

Loading