-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MXCrypto: Move decryptions out of the main thread #1091
Commits on May 19, 2021
-
MXEventDecryptionResult: Add an error property
and make it the single object returned after a decryption
Configuration menu - View commit details
-
Copy full SHA for c1fd75c - Browse repository at this point
Copy the full SHA c1fd75cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 75f5aa8 - Browse repository at this point
Copy the full SHA 75f5aa8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cd77a9 - Browse repository at this point
Copy the full SHA 0cd77a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38df17f - Browse repository at this point
Copy the full SHA 38df17fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e3b6c91 - Browse repository at this point
Copy the full SHA e3b6c91View commit details -
MXCrypto: Change signature of decryptEvents(): Not all events have ev…
…ent id ex: to_device events
Configuration menu - View commit details
-
Copy full SHA for 3938d43 - Browse repository at this point
Copy the full SHA 3938d43View commit details -
MXSession: decryptEvents: Decrypt only encrypted events
and ignore others. Do not consider them as errors
Configuration menu - View commit details
-
Copy full SHA for f5e09cd - Browse repository at this point
Copy the full SHA f5e09cdView commit details -
MXSession: handleSyncResponse: Decrypt asynchronously to_device events
MXCrypto.handleRoomKeyEvent() has been added to know exactly when we can start decrypting.
Configuration menu - View commit details
-
Copy full SHA for 8c2479a - Browse repository at this point
Copy the full SHA 8c2479aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 44ec72d - Browse repository at this point
Copy the full SHA 44ec72dView commit details -
MXEvent: editedEventFromReplacementEvent: Use decrypted replacing eve…
…nt data It solves 2 things: - avoid synchronous decryption - decryption of the MXRoomSummary.lastMessageEvent when it is edited (element-hq/element-ios/issues/4322) Plus it saves a decryption.
Configuration menu - View commit details
-
Copy full SHA for fbde49c - Browse repository at this point
Copy the full SHA fbde49cView commit details -
MXEvent: eventWithNewReferenceRelation: Reuse already decrypted data
to avoid useless (synchronous) decryption like in the previous commit
Configuration menu - View commit details
-
Copy full SHA for 7668262 - Browse repository at this point
Copy the full SHA 7668262View commit details -
Configuration menu - View commit details
-
Copy full SHA for 142554c - Browse repository at this point
Copy the full SHA 142554cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ddfacb - Browse repository at this point
Copy the full SHA 3ddfacbView commit details -
MXSession: eventWithEventId: Decrypt the event if needed.
This will save synchronous decryption
Configuration menu - View commit details
-
Copy full SHA for 7540bd5 - Browse repository at this point
Copy the full SHA 7540bd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6d5f2d - Browse repository at this point
Copy the full SHA e6d5f2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ef3d87 - Browse repository at this point
Copy the full SHA 3ef3d87View commit details -
MXRoomSummary: Reimplement fetchLastMessage
to avoid any synchronous decryption. The algo is probably simpler. It also fixes testGetLastMessageFromPagination, testGetLastMessageFromSeveralPaginations and testFixRoomsSummariesLastMessage tests that have been broken since b4d5ba7
Configuration menu - View commit details
-
Copy full SHA for b0352f2 - Browse repository at this point
Copy the full SHA b0352f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba2f1b5 - Browse repository at this point
Copy the full SHA ba2f1b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9e5d9d - Browse repository at this point
Copy the full SHA f9e5d9dView commit details -
MXRoomSummary: Do not decrypt synchronously lastMessageEvent anymore
lastMessageEvent is required by room list. It took 1.3 seconds on the main thread to get it on my account (600 rooms). Now there are asynchronously preloaded and decrypted when the SDK load. One test has been fixed. As events are now decrypted only upstream and no more on demand, we need to trigger a decrypt to mimic this upstream decryption.
Configuration menu - View commit details
-
Copy full SHA for ee740cd - Browse repository at this point
Copy the full SHA ee740cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 15b0f71 - Browse repository at this point
Copy the full SHA 15b0f71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a87567 - Browse repository at this point
Copy the full SHA 2a87567View commit details -
MXCrypto: Make sure we get algorithm from the wire JSON content
as it is not available in the decrypted JSON content
Configuration menu - View commit details
-
Copy full SHA for 949389a - Browse repository at this point
Copy the full SHA 949389aView commit details -
MXRoomSummary: Implement fetchLastMessage in another way
that does not pollute existing listeners on the live timeline There can be only one component that paginates message from a time else there is will be races.
Configuration menu - View commit details
-
Copy full SHA for e6e7b2c - Browse repository at this point
Copy the full SHA e6e7b2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4534cff - Browse repository at this point
Copy the full SHA 4534cffView commit details -
MXRoom: MXRoom.outgoingMessages does not decrypt messages anymore
Use MXSession.decryptEvents to get decrypted events.
Configuration menu - View commit details
-
Copy full SHA for 000e144 - Browse repository at this point
Copy the full SHA 000e144View commit details -
MXCrypto: Deprecate [MXSession decryptEvent:inTimeline:] and [MXCrypt…
…o decryptEvent:inTimeline:]
Configuration menu - View commit details
-
Copy full SHA for 2275162 - Browse repository at this point
Copy the full SHA 2275162View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa92f6b - Browse repository at this point
Copy the full SHA fa92f6bView commit details -
MXCrypto: eventDeviceInfo: Do not synchronise the operation anymore w…
…ith the decryption queue. A single decryption takes 5ms on an iPhoneX. It was useless to synchronise this method with the busy decryption thread. There is no relationship. Note that this operation uses 0.5ms. It must not be called from the main thread. MatrixKit uses this method to build the timeline. It uses on a dedicated queue.
Configuration menu - View commit details
-
Copy full SHA for 7c23242 - Browse repository at this point
Copy the full SHA 7c23242View commit details -
MXEventTimeline: Fix regression on paginate:
We must not call complete() before returning. It breaks pagination in MatrixKit that uses the returned MXHTTPOperation.
Configuration menu - View commit details
-
Copy full SHA for aa775ff - Browse repository at this point
Copy the full SHA aa775ffView commit details -
MXCrossSigning: Fix a race condition in refreshStateWithSuccess
This method is called from the main thread. It should not use directly elf.crypto.deviceList that is managed by the cryptoQueue.
Configuration menu - View commit details
-
Copy full SHA for 873158b - Browse repository at this point
Copy the full SHA 873158bView commit details
Commits on May 20, 2021
-
Update MatrixSDK/Data/MXEventTimeline.m
Co-authored-by: SBiOSoftWhare <SBiOSoftWhare@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for af236fe - Browse repository at this point
Copy the full SHA af236feView commit details -
Update MatrixSDK/Data/MXEventTimeline.m
Co-authored-by: SBiOSoftWhare <SBiOSoftWhare@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for b95906a - Browse repository at this point
Copy the full SHA b95906aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e58796 - Browse repository at this point
Copy the full SHA 6e58796View commit details -
Merge pull request #1095 from matrix-org/manu/async_decryption2
End of the removal of decryption on the main thread
Configuration menu - View commit details
-
Copy full SHA for d8ed7e2 - Browse repository at this point
Copy the full SHA d8ed7e2View commit details