Live location sharing - Aggregate beacon locations on beacons #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 4, 2022 11:05
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
kerryarchibald
force-pushed
the
psf-866/beacon-relations
branch
from
8223b77
to
75ea743
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2268 +/- ##
===========================================
+ Coverage 59.00% 59.11% +0.11%
===========================================
Files 91 91
Lines 16335 16383 +48
Branches 3768 3779 +11
===========================================
+ Hits 9638 9685 +47
- Misses 6697 6698 +1
|
added 2 commits
April 4, 2022 12:23
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
turt2live
approved these changes
Apr 8, 2022
| const beaconEvent2 = makeBeaconEvent(userId, { timestamp: 1648804528558 }); | ||
| const beaconEvent3 = makeBeaconEvent(userId, { timestamp: 1648804528000 }); | ||
| const beaconEvent4 = makeBeaconEvent(userId, { timestamp: 0 }); | ||
| it('sorts events with timestamps as later than events without', () => { |
There was a problem hiding this comment.
Suggested change
| it('sorts events with timestamps as later than events without', () => { | |
| it('sorts events with timestamps as later than events without', () => { |
| function getContentTimestampWithFallback(event: MatrixEvent): number { | ||
| return M_TIMESTAMP.findIn<number>(event.getContent()) ?? -1; | ||
| } | ||
| /** |
added 4 commits
April 8, 2022 11:22
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
Signed-off-by: Kerry Archibald <kerrya@element.io>
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Apr 30, 2022
* Add MatrixClient.doesServerSupportLogoutDevices() for MSC2457 ([\matrix-org#2297](matrix-org#2297)). * Live location sharing - expose room liveBeaconIds ([\matrix-org#2296](matrix-org#2296)). * Support for MSC2457 logout_devices param for setPassword() ([\matrix-org#2285](matrix-org#2285)). * Stabilise token authenticated registration support ([\matrix-org#2181](matrix-org#2181)). Contributed by @govynnus. * Live location sharing - Aggregate beacon locations on beacons ([\matrix-org#2268](matrix-org#2268)). * Prevent duplicated re-emitter setups in event-mapper ([\matrix-org#2293](matrix-org#2293)). * Make self membership less prone to races ([\matrix-org#2277](matrix-org#2277)). Fixes element-hq/element-web#21661.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process
m.beaconevents, adding them to Beacon state and emitting on change.Here's what your changelog entry will look like:
✨ Features