Move events related to a redacted event into the main timeline #3800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
added
the
T-Defect
andybalaam
force-pushed
the
andybalaam/move-related-of-redacted
branch
from
aaa1b7f
to
f540515
Compare
Base automatically changed from
andybalaam/move-redacted-message-to-main
to
develop
October 18, 2023 07:00
andybalaam
force-pushed
the
andybalaam/move-related-of-redacted
branch
from
9fd2bb6
to
d8fc179
Compare
robintown
approved these changes
Oct 19, 2023
github-merge-queue bot
pushed a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Oct 19, 2023
* Update comments on flaky tests * Enable a test that is fixed by matrix-js-sdk#3800
This was referenced Nov 7, 2023
github-merge-queue bot
pushed a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Nov 15, 2023
* Update comments on flaky tests * Enable a test that is fixed by matrix-js-sdk#3800
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an event is redacted, it loses its relations, meaning it is now part of the main timeline even if it was inside a thread before. This change moves everything that is related to it as well, so that we remain consistent about what thread events are in, even after redactions.
Fixes element-hq/element-web#26388
Follow on from #3798
Part of element-hq/element-web#24392
Here's what your changelog entry will look like:
馃悰 Bug Fixes