Skip to content

Commit

Permalink
Enable test fixed by matrix-org/matrix-js-sdk#3800 (#11764)
Browse files Browse the repository at this point in the history
* Update comments on flaky tests

* Enable a test that is fixed by matrix-js-sdk#3800
  • Loading branch information
andybalaam committed Oct 19, 2023
1 parent fa559cd commit d5ce8f2
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions cypress/e2e/read-receipts/redactions.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ describe("Read receipts", () => {
// Then the room is still read
assertRead(room2);
});
// Flakes because sometimes the unread count stays at 2
// XXX: fails because it flakes because sometimes the unread count stays at 2
it.skip("Reacting to a redacted message leaves the room read", () => {
// Given a redacted message exists
goTo(room1);
Expand Down Expand Up @@ -504,7 +504,7 @@ describe("Read receipts", () => {
goTo(room2);
assertReadThread("Root");
});
// XXX: fails because sometimes the room is still unread after opening the thread (initially)
// XXX: fails because it flakes - sometimes the room is still unread after opening the thread (initially)
it.skip("Reacting to a redacted message leaves the thread read", () => {
// Given a message in a thread was redacted and everything is read
goTo(room1);
Expand Down Expand Up @@ -544,8 +544,7 @@ describe("Read receipts", () => {
// Then the room is unread
assertStillRead(room2);
});
// XXX: fails because the room still shows "1" even though we have read the thread (stuck unread)
it.skip("Reading a reaction to a redacted message marks the thread as read", () => {
it("Reading a thread after a reaction to a redacted message marks the thread as read", () => {
// Given a redacted message in a thread exists, but someone reacted to it before it was redacted
goTo(room1);
receiveMessages(room2, [
Expand All @@ -558,7 +557,7 @@ describe("Read receipts", () => {
receiveMessages(room2, [redactionOf("Msg3")]);
assertUnread(room2, 2);

// When we read the thread, creating a receipt that points at the reaction
// When we read the thread
goTo(room2);
openThread("Root");

Expand Down

0 comments on commit d5ce8f2

Please sign in to comment.