-
-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update audio-player.spec.ts
to reflect the latest status
#10537
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
…dByTestId Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
36 tasks
github-actions
bot
added
Z-Community-PR
Issue is solved by a community member's PR
T-Task
Refactoring, enabling or disabling functionality, other engineering tasks
labels
Apr 6, 2023
alunturner
reviewed
Apr 10, 2023
alunturner
approved these changes
Apr 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Having looked at the whole file now, I'm not sure my comment above has that much value - we're still going to have a good mix of findBy*
type queries in amongst the regular cypress get
type queries.
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
alunturner
approved these changes
Apr 10, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
T-Task
Refactoring, enabling or disabling functionality, other engineering tasks
Z-Community-PR
Issue is solved by a community member's PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to update
audio-player.spec.ts
by replacing the custom commands onfind.ts
and usingfindByTestId
.For element-hq/element-web#25058 and element-hq/element-web#25033
type: task
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.