Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update composer.spec.ts to use findBy* type queries #10538

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Update composer.spec.ts to use findBy* type queries #10538

merged 2 commits into from
Apr 11, 2023

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Apr 6, 2023 •
edited
Loading

This PR intends to update composer.spec.ts by replacing the custom commands offind.ts and using findBy* type queries like findByText.

For element-hq/element-web#25058 and element-hq/element-web#25033

type: task

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Apr 6, 2023
@luixxiul luixxiul mentioned this pull request Apr 6, 2023
Closed
36 tasks
@luixxiul
Update composer.spec.ts - deprecate custom commands
c85c2c4 
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul
Update composer.spec.ts - apply findByText() and findByTestId()
4f66a81 
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
@luixxiul luixxiul changed the title Update composer.spec.ts Update composer.spec.ts to use findBy* type queries Apr 10, 2023
@luixxiul luixxiul marked this pull request as ready for review April 10, 2023 12:35
@luixxiul luixxiul requested a review from a team as a code owner April 10, 2023 12:35
weeman1337
weeman1337 approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @luixxiul

@weeman1337 weeman1337 added this pull request to the merge queue Apr 11, 2023
Merged via the queue into matrix-org:develop with commit a3bc3df Apr 11, 2023
@luixxiul luixxiul deleted the test-composer branch April 11, 2023 09:14
@luixxiul luixxiul mentioned this pull request Apr 11, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weeman1337 weeman1337 weeman1337 approved these changes

@germain-gg germain-gg Awaiting requested review from germain-gg germain-gg is a code owner automatically assigned from matrix-org/element-web-reviewers

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luixxiul @weeman1337