Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor element call lobby + skip lobby #12057

Merged
merged 58 commits into from Jan 29, 2024
Merged

Refactor element call lobby + skip lobby #12057

merged 58 commits into from Jan 29, 2024

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Dec 14, 2023 •
edited

This PR can be reviewed per commit:

  • The first commit updates the embedding to use the lobby that is supported by Element Call (instead of the custom EW lobby). We also update the EC url generation to use template variables. (this allows to store the configuration in widget.data which makes it easy to parse the current widget configuration.
  • The second commit hooks up various places where one can join/start a call so that shiftKey+click will skip the lobby.
  • The last commit removes all the code that is not needed anymore. (Lobby UI)

All the following commits refactor and add a lot of testing changes.
Signed-off-by: Timo K toger5@hotmail.de
Requires: element-hq/element-web#26879

Alert

In its current state this breaks Jitsi (because its removing the lobby code entirely)

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

  • Refactor element call lobby + skip lobby (#12057). Contributed by @toger5.

@toger5
Refactor ElementCall to use the widget lobby.
9bca273 
 - expose skip lobby
 - use the widget.data to build the widget url

Signed-off-by: Timo K <toger5@hotmail.de>
@toger5
Use shiftKey click to skip the lobby
6d5ac0b 
Signed-off-by: Timo K <toger5@hotmail.de>
@toger5 toger5 requested a review from a team as a code owner December 14, 2023 18:37
@toger5 toger5 added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Dec 14, 2023
@toger5 toger5 force-pushed the toger5/skip_lobby branch 2 times, most recently from f984491 to 9d1a3f4 Compare December 14, 2023 18:43
@toger5
remove Lobby component
8ed0454 
Signed-off-by: Timo K <toger5@hotmail.de>
@toger5
update tests + remove EW lobby related tests
2518d56 
Signed-off-by: Timo K <toger5@hotmail.de>
@toger5
remove lobby device button tests
01d63df 
Signed-off-by: Timo K <toger5@hotmail.de>
@toger5
i18n
b12d176 
Signed-off-by: Timo K <toger5@hotmail.de>
@toger5
use voip participant label
448403c 
Signed-off-by: Timo K <toger5@hotmail.de>
@toger5
update tests
ce76630 
Signed-off-by: Timo K <toger5@hotmail.de>
@toger5
fix rounded corners in pip
f01b155 
Signed-off-by: Timo K <toger5@hotmail.de>
@toger5
allow joining call in legacy room header (without banner)
68808fb 
Signed-off-by: Timo K <toger5@hotmail.de>
@toger5
Introduce new connection states for calls.
821211a 
And use them for integrated lobby.

Signed-off-by: Timo K <toger5@hotmail.de>
@robintown robintown mentioned this pull request Jan 25, 2024
Merged
3 tasks
toger5 and others added 2 commits January 25, 2024 12:49
@toger5 @robintown
Update playwright/e2e/room/room-header.spec.ts
83e0374 
Co-authored-by: Robin <robin@robin.town>
@toger5 @robintown
Update src/components/views/voip/CallView.tsx
9d61bc4 
Co-authored-by: Robin <robin@robin.town>
@toger5
review
09344a5 
rename connect -> start
isVideoRoom not dependant on feature flags
rename allOtherCallsDisconnected -> disconnectAllOtherCalls

Signed-off-by: Timo K <toger5@hotmail.de>
@toger5
check for EC widget
7673e5f 
Signed-off-by: Timo K <toger5@hotmail.de>
@toger5
dep array
f97fb9b 
Signed-off-by: Timo K <toger5@hotmail.de>
@toger5
rename in spyOn
f25c2ea 
Signed-off-by: Timo K <toger5@hotmail.de>
@toger5 toger5 requested a review from robintown January 26, 2024 09:21
@toger5 toger5 enabled auto-merge January 29, 2024 15:45
@toger5 toger5 added this pull request to the merge queue Jan 29, 2024
Merged via the queue into develop with commit a370a5c Jan 29, 2024
22 checks passed
@toger5 toger5 deleted the toger5/skip_lobby branch January 29, 2024 16:28
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Feb 14, 2024
@bmwiedemann
Update element-web to version 1.11.58 / rev 50 via SR 1146558
1a8457b 
https://build.opensuse.org/request/show/1146558
by user dheidler + anag+factory
- Version 1.11.58
  ## ✨ Features

   * 🦀  🔒 **The flag to enable the Rust crypto implementation is now set to `true` by default. This means that without any additional configuration every new login will use the new cryptography implementation.**
  * Add Element call related functionality to new room header (matrix-org/matrix-react-sdk#12091). Contributed by @toger5.
  * Add labs flag for Threads Activity Centre (matrix-org/matrix-react-sdk#12137). Contributed by @florianduros.
  * Refactor element call lobby + skip lobby (matrix-org/matrix-react-sdk#12057). Contributed by @toger5.
  * Hide the "Message" button in the sidebar if the CreateRooms components should not be shown (https://github.com/matrix-org/matrix-react
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Feb 14, 2024
@bmwiedemann
Update element-desktop to version 1.11.58 / rev 51 via SR 1146559
787af6e 
https://build.opensuse.org/request/show/1146559
by user dheidler + anag+factory
- Version 1.11.58
  * 🦀  🔒 **The flag to enable the Rust crypto implementation is now set to `true` by default. This means that without any additional configuration every new login will use the new cryptography implementation.**
  * Add Element call related functionality to new room header (matrix-org/matrix-react-sdk#12091). Contributed by @toger5.
  * Add labs flag for Threads Activity Centre (matrix-org/matrix-react-sdk#12137). Contributed by @florianduros.
  * Refactor element call lobby + skip lobby (matrix-org/matrix-react-sdk#12057). Contributed by @toger5.
  * Hide the "Message" button in the sidebar if the CreateRooms components should not be shown (matrix-org/matrix-react-sdk#9271). Con
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Mar 3, 2024
@Midar
Update chat/element-web to 1.11.59
16e3e38 
Changes in [1.11.59](https://github.com/element-hq/element-web/releases/tag/v1.11.59) (2024-02-27)
==================================================================================================
## 🦖 Deprecations

* Enable custom themes to theme Compound ([#12240](matrix-org/matrix-react-sdk#12240)). Contributed by @robintown.
* Remove welcome bot `welcome_user_id` support ([#12153](matrix-org/matrix-react-sdk#12153)). Contributed by @t3chguy.

## ✨ Features

* Ignore activity in TAC ([#12269](matrix-org/matrix-react-sdk#12269)). Contributed by @florianduros.
* Use browser's font size instead of hardcoded `16px` as root font size ([#12246](matrix-org/matrix-react-sdk#12246)). Contributed by @florianduros.
* Revert "Use Compound primary colors for most actions" ([#12264](matrix-org/matrix-react-sdk#12264)). Contributed by @florianduros.
* Revert "Refine menu, toast, and popover colors" ([#12263](matrix-org/matrix-react-sdk#12263)). Contributed by @florianduros.
* Fix Native OIDC for Element Desktop ([#12253](matrix-org/matrix-react-sdk#12253)). Contributed by @t3chguy.
* Improve client metadata used for OIDC dynamic registration ([#12257](matrix-org/matrix-react-sdk#12257)). Contributed by @t3chguy.
* Refine menu, toast, and popover colors ([#12247](matrix-org/matrix-react-sdk#12247)). Contributed by @robintown.
* Call the AsJson forms of import and exportRoomKeys ([#12233](matrix-org/matrix-react-sdk#12233)). Contributed by @andybalaam.
* Use Compound primary colors for most actions ([#12241](matrix-org/matrix-react-sdk#12241)). Contributed by @robintown.
* Enable redirected media by default ([#12142](matrix-org/matrix-react-sdk#12142)). Contributed by @turt2live.
* Reduce TAC width by `16px` ([#12239](matrix-org/matrix-react-sdk#12239)). Contributed by @florianduros.
* Pop out of Threads Activity Centre ([#12136](matrix-org/matrix-react-sdk#12136)). Contributed by @florianduros.
* Use new semantic tokens for username colors ([#12209](matrix-org/matrix-react-sdk#12209)). Contributed by @robintown.

## 🐛 Bug Fixes

* [Backport staging] Fix spurious session corruption error ([#12287](matrix-org/matrix-react-sdk#12287)). Contributed by @RiotRobot.
* Fix the space panel getting bigger when gaining a scroll bar ([#12267](matrix-org/matrix-react-sdk#12267)). Contributed by @dbkr.
* Fix gradients spacings on the space panel ([#12262](matrix-org/matrix-react-sdk#12262)). Contributed by @dbkr.
* Remove hardcoded `Element` in tac labs description ([#12266](matrix-org/matrix-react-sdk#12266)). Contributed by @florianduros.
* Fix branding in "migrating crypto" message ([#12265](matrix-org/matrix-react-sdk#12265)). Contributed by @richvdh.
* Use h1 as first heading in dialogs ([#12250](matrix-org/matrix-react-sdk#12250)). Contributed by @dbkr.
* Fix forced lowercase username in login/registration flows ([#9329](matrix-org/matrix-react-sdk#9329)). Contributed by @vrifox.
* Update the TAC indicator on event decryption ([#12243](matrix-org/matrix-react-sdk#12243)). Contributed by @dbkr.
* Fix OIDC delegated auth account url check ([#12242](matrix-org/matrix-react-sdk#12242)). Contributed by @t3chguy.
* New Header edgecase fixes: Close lobby button not shown, disable join button in various places, more... ([#12235](matrix-org/matrix-react-sdk#12235)). Contributed by @toger5.
* Fix TAC button alignment when expanded ([#12238](matrix-org/matrix-react-sdk#12238)). Contributed by @florianduros.
* Fix tooltip behaviour in TAC ([#12236](matrix-org/matrix-react-sdk#12236)). Contributed by @florianduros.



Changes in [1.11.58](https://github.com/element-hq/element-web/releases/tag/v1.11.58) (2024-02-13)
==================================================================================================
## ✨ Features

 * 🦀  🔒 **The flag to enable the Rust crypto implementation is now set to `true` by default. This means that without any additional configuration every new login will use the new cryptography implementation.**
* Add Element call related functionality to new room header ([#12091](matrix-org/matrix-react-sdk#12091)). Contributed by @toger5.
* Add labs flag for Threads Activity Centre ([#12137](matrix-org/matrix-react-sdk#12137)). Contributed by @florianduros.
* Refactor element call lobby + skip lobby ([#12057](matrix-org/matrix-react-sdk#12057)). Contributed by @toger5.
* Hide the "Message" button in the sidebar if the CreateRooms components should not be shown ([#9271](matrix-org/matrix-react-sdk#9271)). Contributed by @dhenneke.
* Add notification dots to thread summary icons ([#12146](matrix-org/matrix-react-sdk#12146)). Contributed by @dbkr.

## 🐛 Bug Fixes

* [Backport staging] Fix the StorageManger detecting a false positive consistency check when manually migrating to rust from labs ([#12230](matrix-org/matrix-react-sdk#12230)). Contributed by @RiotRobot.
* Fix logout can take ages ([#12191](matrix-org/matrix-react-sdk#12191)). Contributed by @BillCarsonFr.
* Fix `Mark all as read` in settings ([#12205](matrix-org/matrix-react-sdk#12205)). Contributed by @florianduros.
* Fix default thread notification of the new RoomHeader ([#12194](matrix-org/matrix-react-sdk#12194)). Contributed by @florianduros.
* Fix display of room notification debug info ([#12183](matrix-org/matrix-react-sdk#12183)). Contributed by @dbkr.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robintown robintown robintown approved these changes

Assignees
No one assigned
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@toger5 @robintown