Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable custom themes to theme Compound #12240

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

robintown
Copy link
Member

@robintown robintown commented Feb 9, 2024

This adds a simple compound section to custom themes that enables any of Compound's semantic tokens to be overriden, like so:

{
  ...
  "setting_defaults": {
    "custom_themes": [
      {
        "name": "My Theme",
        "is_dark": false,
        "fonts": {
          ...
        },
        "colors": {
          ...
        },
        "compound": {
          "--cpd-color-icon-accent-tertiary": "var(--cpd-color-blue-800)",
          "--cpd-color-text-action-accent": "var(--cpd-color-blue-900)"
        }
      }
    ]
  }
}

Closes element-hq/element-web#26285
Requires element-hq/element-web#26993
Requires element-hq/element-web#27004

Notes: Enable custom themes to theme Compound, and remove the previous username-colors and avatar-background-colors options. To customize user/avatar colors, you must instead override the --cpd-color-text-decorative- and --cpd-color-bg-decorative- design tokens provided by Compound. See the documentation.


Here's what your changelog entry will look like:

🦖 Deprecations

  • Enable custom themes to theme Compound, and remove the previous username-colors and avatar-background-colors options. To customize user/avatar colors, you must instead override the --cpd-color-text-decorative- and --cpd-color-bg-decorative- design tokens [provided by Compound](https (#12240). Fixes Respect theme avatar-background-colors element-hq/element-web#26285.

@robintown robintown added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Feb 9, 2024
They are replaced by the Compound theming options (specifically, username colors can be themed by changing the color of Compound's decorative color tokens).
robintown added a commit to robintown/element-web that referenced this pull request Feb 13, 2024
To reflect the changes in matrix-org/matrix-react-sdk#12240, including the removal of the username and color options (those are now themed through Compound)
@robintown robintown marked this pull request as ready for review February 13, 2024 05:15
@robintown robintown requested review from a team as code owners February 13, 2024 05:15
@t3chguy t3chguy added T-Deprecation and removed X-Breaking-Change T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels Feb 13, 2024
@t3chguy
Copy link
Member

t3chguy commented Feb 13, 2024

This isn't a real SDK so we don't maintain backwards compatibility nor full semver, worth raising as a deprecation so its higher in the changelog though

@robintown
Copy link
Member Author

Ah thanks, I didn't realize we had a deprecation option for changelogs

@robintown robintown removed the request for review from MidhunSureshR February 13, 2024 14:07
@robintown robintown added this pull request to the merge queue Feb 13, 2024
Merged via the queue into matrix-org:develop with commit 8bbad9f Feb 13, 2024
41 of 45 checks passed
@robintown robintown deleted the compound-theming branch February 13, 2024 14:29
@PeterKleinTele2
Copy link

This is great news. Thanks to all involved!

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Mar 3, 2024
Changes in [1.11.59](https://github.com/element-hq/element-web/releases/tag/v1.11.59) (2024-02-27)
==================================================================================================
## 🦖 Deprecations

* Enable custom themes to theme Compound ([#12240](matrix-org/matrix-react-sdk#12240)). Contributed by @robintown.
* Remove welcome bot `welcome_user_id` support ([#12153](matrix-org/matrix-react-sdk#12153)). Contributed by @t3chguy.

## ✨ Features

* Ignore activity in TAC ([#12269](matrix-org/matrix-react-sdk#12269)). Contributed by @florianduros.
* Use browser's font size instead of hardcoded `16px` as root font size ([#12246](matrix-org/matrix-react-sdk#12246)). Contributed by @florianduros.
* Revert "Use Compound primary colors for most actions" ([#12264](matrix-org/matrix-react-sdk#12264)). Contributed by @florianduros.
* Revert "Refine menu, toast, and popover colors" ([#12263](matrix-org/matrix-react-sdk#12263)). Contributed by @florianduros.
* Fix Native OIDC for Element Desktop ([#12253](matrix-org/matrix-react-sdk#12253)). Contributed by @t3chguy.
* Improve client metadata used for OIDC dynamic registration ([#12257](matrix-org/matrix-react-sdk#12257)). Contributed by @t3chguy.
* Refine menu, toast, and popover colors ([#12247](matrix-org/matrix-react-sdk#12247)). Contributed by @robintown.
* Call the AsJson forms of import and exportRoomKeys ([#12233](matrix-org/matrix-react-sdk#12233)). Contributed by @andybalaam.
* Use Compound primary colors for most actions ([#12241](matrix-org/matrix-react-sdk#12241)). Contributed by @robintown.
* Enable redirected media by default ([#12142](matrix-org/matrix-react-sdk#12142)). Contributed by @turt2live.
* Reduce TAC width by `16px` ([#12239](matrix-org/matrix-react-sdk#12239)). Contributed by @florianduros.
* Pop out of Threads Activity Centre ([#12136](matrix-org/matrix-react-sdk#12136)). Contributed by @florianduros.
* Use new semantic tokens for username colors ([#12209](matrix-org/matrix-react-sdk#12209)). Contributed by @robintown.

## 🐛 Bug Fixes

* [Backport staging] Fix spurious session corruption error ([#12287](matrix-org/matrix-react-sdk#12287)). Contributed by @RiotRobot.
* Fix the space panel getting bigger when gaining a scroll bar ([#12267](matrix-org/matrix-react-sdk#12267)). Contributed by @dbkr.
* Fix gradients spacings on the space panel ([#12262](matrix-org/matrix-react-sdk#12262)). Contributed by @dbkr.
* Remove hardcoded `Element` in tac labs description ([#12266](matrix-org/matrix-react-sdk#12266)). Contributed by @florianduros.
* Fix branding in "migrating crypto" message ([#12265](matrix-org/matrix-react-sdk#12265)). Contributed by @richvdh.
* Use h1 as first heading in dialogs ([#12250](matrix-org/matrix-react-sdk#12250)). Contributed by @dbkr.
* Fix forced lowercase username in login/registration flows ([#9329](matrix-org/matrix-react-sdk#9329)). Contributed by @vrifox.
* Update the TAC indicator on event decryption ([#12243](matrix-org/matrix-react-sdk#12243)). Contributed by @dbkr.
* Fix OIDC delegated auth account url check ([#12242](matrix-org/matrix-react-sdk#12242)). Contributed by @t3chguy.
* New Header edgecase fixes: Close lobby button not shown, disable join button in various places, more... ([#12235](matrix-org/matrix-react-sdk#12235)). Contributed by @toger5.
* Fix TAC button alignment when expanded ([#12238](matrix-org/matrix-react-sdk#12238)). Contributed by @florianduros.
* Fix tooltip behaviour in TAC ([#12236](matrix-org/matrix-react-sdk#12236)). Contributed by @florianduros.



Changes in [1.11.58](https://github.com/element-hq/element-web/releases/tag/v1.11.58) (2024-02-13)
==================================================================================================
## ✨ Features

 * 🦀  🔒 **The flag to enable the Rust crypto implementation is now set to `true` by default. This means that without any additional configuration every new login will use the new cryptography implementation.**
* Add Element call related functionality to new room header ([#12091](matrix-org/matrix-react-sdk#12091)). Contributed by @toger5.
* Add labs flag for Threads Activity Centre ([#12137](matrix-org/matrix-react-sdk#12137)). Contributed by @florianduros.
* Refactor element call lobby + skip lobby ([#12057](matrix-org/matrix-react-sdk#12057)). Contributed by @toger5.
* Hide the "Message" button in the sidebar if the CreateRooms components should not be shown ([#9271](matrix-org/matrix-react-sdk#9271)). Contributed by @dhenneke.
* Add notification dots to thread summary icons ([#12146](matrix-org/matrix-react-sdk#12146)). Contributed by @dbkr.

## 🐛 Bug Fixes

* [Backport staging] Fix the StorageManger detecting a false positive consistency check when manually migrating to rust from labs ([#12230](matrix-org/matrix-react-sdk#12230)). Contributed by @RiotRobot.
* Fix logout can take ages ([#12191](matrix-org/matrix-react-sdk#12191)). Contributed by @BillCarsonFr.
* Fix `Mark all as read` in settings ([#12205](matrix-org/matrix-react-sdk#12205)). Contributed by @florianduros.
* Fix default thread notification of the new RoomHeader ([#12194](matrix-org/matrix-react-sdk#12194)). Contributed by @florianduros.
* Fix display of room notification debug info ([#12183](matrix-org/matrix-react-sdk#12183)). Contributed by @dbkr.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Respect theme avatar-background-colors
3 participants