Element Call: fix widget shown while its still loading (`waitForIframeLoad=false`) #12292

toger5 · 2024-02-27T20:38:22Z

Show loading spinner also if waitForIframeLoad = false.
Configure EC so it waits for the content loaded action.

This prohibits the error message:

Uncaught (in promise) Error: Improper sequence: not expecting ContentLoaded event if waitForIframeLoad is true (default=true)

!WARNING This breaks compatibility with the full mesh branch.
I would like to discuss here if/when we can do that.

Signed-off-by: Timo K toger5@hotmail.de

Checklist

Tests written for new code (and old code if feasible)
Linter and other CI checks pass
Sign-off given on the changes (see CONTRIBUTING.md)

Configure EC so it waits for the content loaded action !WARNING This breaks compatibility with the full mesh branch. I would like to discuss here if/when we can do that. Signed-off-by: Timo K <toger5@hotmail.de>

dbkr

So basically we are deciding that now is the time to drop support for any version of EC that doesn't support waitForIframeLoad: false? I think that seems fine: it has been quite some time. As you say, full mesh will no longer work but that may be fine.

And yeah, I'm not convinced about only passing the loading flag if waitForIframeLoad was true, I can't really make much sense of it and I can't think why we would have done it. I can't wait until this confusing flag is gone forever.

Could it get a type label and a more changelog-friendly title please?

Signed-off-by: Timo K <toger5@hotmail.de>

toger5 · 2024-02-28T20:12:28Z

@dbkr updated the title and added T-Enhancement.

So basically we are deciding that now is the time to drop support for any version of EC that doesn't support waitForIframeLoad: false? I think that seems fine: it has been quite some time. As you say, full mesh will no longer work but that may be fine.

And yeah, I'm not convinced about only passing the loading flag if waitForIframeLoad was true, I can't really make much sense of it and I can't think why we would have done it. I can't wait until this confusing flag is gone forever.

Nice that you agree with those.

Signed-off-by: Timo K <toger5@hotmail.de>

… widgets) Signed-off-by: Timo K <toger5@hotmail.de>

toger5 · 2024-03-01T12:42:57Z

test/components/views/elements/__snapshots__/AppTile-test.tsx.snap

Those snaps are now updated since we dont show the loading view for IFrames that have waitForIframeLoad=true (That are considered ready once the IFrame is ready.)

It would be possible to use the "preparing" event to show a spinner in the waitForIframeLoad=true cases. But to me it looks like this is how it was intended to be. (I dont see why waitForIFrame would have been used in getNewState otherwise)

* Upgrade dependency to matrix-js-sdk@31.5.0-rc.0 * v3.94.0-rc.0 * Handle up/down as well as left/right for horizontal toolbars for improved a11y (matrix-org#12305) Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Remove references to internal js-sdk type `CryptoBackend` (matrix-org#12321) * Remove references to internal js-sdk type `CryptoBackend` * Use `Paramteters` to avoid `ts-ignore` * Use `strong` element to semantically denote visually emphasised content (matrix-org#12320) * Use `strong` element to semantically denote visually emphasised content Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Update snapshots Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Add comment Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> --------- Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Remove unused slider component (matrix-org#12303) It is unused as of matrix-org#12246. I noticed this while working on matrix-org#12299. * Update matrix-org (matrix-org#11966) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update all non-major dependencies (matrix-org#12322) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency stylelint-scss to v6.2.0 (matrix-org#12323) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency @vector-im/compound-web to v3.1.3 (matrix-org#12281) * Update dependency @vector-im/compound-web to v3.1.3 * Update snapshots Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Update snapshots Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Update snapshots Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Fix TAC width due to compound update (matrix-org#12326) --------- Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Telatynski <7t3chguy@gmail.com> Co-authored-by: Florian Duros <florianduros@element.io> * Call guest access link creation to join calls as a non registered user via the EC SPA (matrix-org#12259) * Add externall call link button if in public call room Signed-off-by: Timo K <toger5@hotmail.de> * Allow configuring a spa homeserver url. Signed-off-by: Timo K <toger5@hotmail.de> * temp Signed-off-by: Timo K <toger5@hotmail.de> * remove homeserver url Signed-off-by: Timo K <toger5@hotmail.de> * Add custom title to share dialog. So that we can use it as a "share call" dialog. Signed-off-by: Timo K <toger5@hotmail.de> * - rename config options - only show link button if a guest url is provided - share dialog custom Title - rename call share labels Signed-off-by: Timo K <toger5@hotmail.de> * rename to title_link Signed-off-by: Timo K <toger5@hotmail.de> * add tests for ShareDialog Signed-off-by: Timo K <toger5@hotmail.de> * add tests for share call button Signed-off-by: Timo K <toger5@hotmail.de> * review Signed-off-by: Timo K <toger5@hotmail.de> * remove comment Signed-off-by: Timo K <toger5@hotmail.de> * Update src/components/views/dialogs/ShareDialog.tsx Co-authored-by: David Baker <dbkr@users.noreply.github.com> --------- Signed-off-by: Timo K <toger5@hotmail.de> Co-authored-by: David Baker <dbkr@users.noreply.github.com> * Fix spotlight opening in TAC (matrix-org#12315) * Fix spotlight opening in TAC * Add tests * Remove `RovingTabIndexProvider` * Reset power selector on API failure to prevent state mismatch (matrix-org#12319) * Reset power selector on API failure to prevent state mismatch Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Allow onChange to be sync or async Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Add unmounted check Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Improve coverage Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Iterate Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> --------- Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Use correct push rule to evaluate room-wide mentions (matrix-org#12318) Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Improve Forward Dialog a11y by switching to roving tab index interactions (matrix-org#12306) * Improve Forward Dialog a11y by switching to roving tab index interactions Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Improve screen reader readout Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Improve screen reader readout Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Add tests Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> --------- Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * [create-pull-request] automated change (matrix-org#12330) Co-authored-by: github-merge-queue <github-merge-queue@users.noreply.github.com> * Reuse media content/info types from the js-sdk (matrix-org#12308) * TAC: Fix CSS & component typos (matrix-org#12333) * Fix CSS & component typo * Update snapshots * Element Call: fix widget shown while its still loading (`waitForIframeLoad=false`) (matrix-org#12292) * show loading spinner also if waitForIframeLoad = false Configure EC so it waits for the content loaded action !WARNING This breaks compatibility with the full mesh branch. I would like to discuss here if/when we can do that. Signed-off-by: Timo K <toger5@hotmail.de> * stop show loading screen on widget ready (instead of preparing) Signed-off-by: Timo K <toger5@hotmail.de> * wait until widget loading is over before comparing screenshots Signed-off-by: Timo K <toger5@hotmail.de> * fix waitForIFrame=true widgets Signed-off-by: Timo K <toger5@hotmail.de> * test Signed-off-by: Timo K <toger5@hotmail.de> * always start with loading true. + cleanup Signed-off-by: Timo K <toger5@hotmail.de> * simplify loading Signed-off-by: Timo K <toger5@hotmail.de> * update snapshots (start not in loading state for waitForIframe = true widgets) Signed-off-by: Timo K <toger5@hotmail.de> --------- Signed-off-by: Timo K <toger5@hotmail.de> * Upgrade dependency to matrix-js-sdk@31.5.0 * v3.94.0 * Resetting package fields for development * Reset matrix-js-sdk back to develop branch --------- Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> Signed-off-by: Timo K <toger5@hotmail.de> Co-authored-by: RiotRobot <releases@riot.im> Co-authored-by: Michael Telatynski <7t3chguy@gmail.com> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Co-authored-by: Robin <robin@robin.town> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Florian Duros <florianduros@element.io> Co-authored-by: Timo <16718859+toger5@users.noreply.github.com> Co-authored-by: David Baker <dbkr@users.noreply.github.com> Co-authored-by: github-merge-queue <github-merge-queue@users.noreply.github.com>

* Upgrade dependency to matrix-js-sdk@31.5.0-rc.0 * v3.94.0-rc.0 * Handle up/down as well as left/right for horizontal toolbars for improved a11y (matrix-org#12305) Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Remove references to internal js-sdk type `CryptoBackend` (matrix-org#12321) * Remove references to internal js-sdk type `CryptoBackend` * Use `Paramteters` to avoid `ts-ignore` * Use `strong` element to semantically denote visually emphasised content (matrix-org#12320) * Use `strong` element to semantically denote visually emphasised content Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Update snapshots Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Add comment Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> --------- Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Remove unused slider component (matrix-org#12303) It is unused as of matrix-org#12246. I noticed this while working on matrix-org#12299. * Update matrix-org (matrix-org#11966) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update all non-major dependencies (matrix-org#12322) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency stylelint-scss to v6.2.0 (matrix-org#12323) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update dependency @vector-im/compound-web to v3.1.3 (matrix-org#12281) * Update dependency @vector-im/compound-web to v3.1.3 * Update snapshots Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Update snapshots Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Update snapshots Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Fix TAC width due to compound update (matrix-org#12326) --------- Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Telatynski <7t3chguy@gmail.com> Co-authored-by: Florian Duros <florianduros@element.io> * Call guest access link creation to join calls as a non registered user via the EC SPA (matrix-org#12259) * Add externall call link button if in public call room Signed-off-by: Timo K <toger5@hotmail.de> * Allow configuring a spa homeserver url. Signed-off-by: Timo K <toger5@hotmail.de> * temp Signed-off-by: Timo K <toger5@hotmail.de> * remove homeserver url Signed-off-by: Timo K <toger5@hotmail.de> * Add custom title to share dialog. So that we can use it as a "share call" dialog. Signed-off-by: Timo K <toger5@hotmail.de> * - rename config options - only show link button if a guest url is provided - share dialog custom Title - rename call share labels Signed-off-by: Timo K <toger5@hotmail.de> * rename to title_link Signed-off-by: Timo K <toger5@hotmail.de> * add tests for ShareDialog Signed-off-by: Timo K <toger5@hotmail.de> * add tests for share call button Signed-off-by: Timo K <toger5@hotmail.de> * review Signed-off-by: Timo K <toger5@hotmail.de> * remove comment Signed-off-by: Timo K <toger5@hotmail.de> * Update src/components/views/dialogs/ShareDialog.tsx Co-authored-by: David Baker <dbkr@users.noreply.github.com> --------- Signed-off-by: Timo K <toger5@hotmail.de> Co-authored-by: David Baker <dbkr@users.noreply.github.com> * Fix spotlight opening in TAC (matrix-org#12315) * Fix spotlight opening in TAC * Add tests * Remove `RovingTabIndexProvider` * Reset power selector on API failure to prevent state mismatch (matrix-org#12319) * Reset power selector on API failure to prevent state mismatch Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Allow onChange to be sync or async Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Add unmounted check Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Improve coverage Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Iterate Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> --------- Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Use correct push rule to evaluate room-wide mentions (matrix-org#12318) Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Improve Forward Dialog a11y by switching to roving tab index interactions (matrix-org#12306) * Improve Forward Dialog a11y by switching to roving tab index interactions Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Improve screen reader readout Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Improve screen reader readout Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * Add tests Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> --------- Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> * [create-pull-request] automated change (matrix-org#12330) Co-authored-by: github-merge-queue <github-merge-queue@users.noreply.github.com> * Reuse media content/info types from the js-sdk (matrix-org#12308) * TAC: Fix CSS & component typos (matrix-org#12333) * Fix CSS & component typo * Update snapshots * Element Call: fix widget shown while its still loading (`waitForIframeLoad=false`) (matrix-org#12292) * show loading spinner also if waitForIframeLoad = false Configure EC so it waits for the content loaded action !WARNING This breaks compatibility with the full mesh branch. I would like to discuss here if/when we can do that. Signed-off-by: Timo K <toger5@hotmail.de> * stop show loading screen on widget ready (instead of preparing) Signed-off-by: Timo K <toger5@hotmail.de> * wait until widget loading is over before comparing screenshots Signed-off-by: Timo K <toger5@hotmail.de> * fix waitForIFrame=true widgets Signed-off-by: Timo K <toger5@hotmail.de> * test Signed-off-by: Timo K <toger5@hotmail.de> * always start with loading true. + cleanup Signed-off-by: Timo K <toger5@hotmail.de> * simplify loading Signed-off-by: Timo K <toger5@hotmail.de> * update snapshots (start not in loading state for waitForIframe = true widgets) Signed-off-by: Timo K <toger5@hotmail.de> --------- Signed-off-by: Timo K <toger5@hotmail.de> * Upgrade dependency to matrix-js-sdk@31.5.0 * v3.94.0 * Resetting package fields for development * Reset matrix-js-sdk back to develop branch * Refine styles of menus, toasts, popovers, and modals (matrix-org#12332) * Refine styles of menus, toasts, popovers, and modals This is a reintroduction of matrix-org#12247, with the difference that modal styles have now been refreshed as well. * Restore the fixed heights of some dialogs * Fix formatting and flaky screenshot * Make EC widget theme reactive - Update widget url when the theme changes (matrix-org#12295) * update widget url when the theme changes Signed-off-by: Timo K <toger5@hotmail.de> * quick "make it EC specific" workaround proposal. Signed-off-by: Timo K <toger5@hotmail.de> * use `matches` Signed-off-by: Timo K <toger5@hotmail.de> * test coverage Signed-off-by: Timo K <toger5@hotmail.de> * more test coverage Signed-off-by: Timo K <toger5@hotmail.de> * fix jest Signed-off-by: Timo K <toger5@hotmail.de> * add tests for theme changes Signed-off-by: Timo K <toger5@hotmail.de> * update snapshots Signed-off-by: Timo K <toger5@hotmail.de> * test for theme update with non ec widget Signed-off-by: Timo K <toger5@hotmail.de> * add dark custom theme widget url Signed-off-by: Timo K <toger5@hotmail.de> * trigger conditions for theme cleanup Signed-off-by: Timo K <toger5@hotmail.de> * update tests using testId Signed-off-by: Timo K <toger5@hotmail.de> * use typed event emitter for theme watcher Signed-off-by: Timo K <toger5@hotmail.de> * simplify condition Signed-off-by: Timo K <toger5@hotmail.de> --------- Signed-off-by: Timo K <toger5@hotmail.de> --------- Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> Signed-off-by: Timo K <toger5@hotmail.de> Co-authored-by: RiotRobot <releases@riot.im> Co-authored-by: Michael Telatynski <7t3chguy@gmail.com> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Co-authored-by: Robin <robin@robin.town> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Florian Duros <florianduros@element.io> Co-authored-by: Timo <16718859+toger5@users.noreply.github.com> Co-authored-by: David Baker <dbkr@users.noreply.github.com> Co-authored-by: github-merge-queue <github-merge-queue@users.noreply.github.com>

…eLoad=false`) (#12292) * show loading spinner also if waitForIframeLoad = false Configure EC so it waits for the content loaded action !WARNING This breaks compatibility with the full mesh branch. I would like to discuss here if/when we can do that. Signed-off-by: Timo K <toger5@hotmail.de> * stop show loading screen on widget ready (instead of preparing) Signed-off-by: Timo K <toger5@hotmail.de> * wait until widget loading is over before comparing screenshots Signed-off-by: Timo K <toger5@hotmail.de> * fix waitForIFrame=true widgets Signed-off-by: Timo K <toger5@hotmail.de> * test Signed-off-by: Timo K <toger5@hotmail.de> * always start with loading true. + cleanup Signed-off-by: Timo K <toger5@hotmail.de> * simplify loading Signed-off-by: Timo K <toger5@hotmail.de> * update snapshots (start not in loading state for waitForIframe = true widgets) Signed-off-by: Timo K <toger5@hotmail.de> --------- Signed-off-by: Timo K <toger5@hotmail.de>

show loading spinner also if waitForIframeLoad = false

1696767

Configure EC so it waits for the content loaded action !WARNING This breaks compatibility with the full mesh branch. I would like to discuss here if/when we can do that. Signed-off-by: Timo K <toger5@hotmail.de>

toger5 requested a review from a team as a code owner February 27, 2024 20:38

toger5 requested review from dbkr and richvdh February 27, 2024 20:38

github-actions bot deployed to Netlify February 27, 2024 20:41 View deployment

github-actions bot deployed to EndToEndTests February 27, 2024 20:59 View deployment

dbkr reviewed Feb 28, 2024

View reviewed changes

toger5 added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Feb 28, 2024

stop show loading screen on widget ready (instead of preparing)

f7b0035

Signed-off-by: Timo K <toger5@hotmail.de>

github-actions bot deployed to Netlify February 28, 2024 15:37 View deployment

github-actions bot deployed to EndToEndTests February 28, 2024 15:54 View deployment

toger5 mentioned this pull request Feb 28, 2024

Theme loading without flickering element-hq/element-call#2233

Merged

toger5 changed the title ~~Widget loading procedure patch~~ Element Call: fix widget shown before done loading (waitForIframeLoad=false) Feb 28, 2024

toger5 changed the title ~~Element Call: fix widget shown before done loading (waitForIframeLoad=false)~~ Element Call: fix widget shown before done loading (waitForIframeLoad=false) Feb 28, 2024

toger5 changed the title ~~Element Call: fix widget shown before done loading (waitForIframeLoad=false)~~ Element Call: fix widget shown before its done loading (waitForIframeLoad=false) Feb 28, 2024

toger5 changed the title ~~Element Call: fix widget shown before its done loading (waitForIframeLoad=false)~~ Element Call: fix widget shown while its still loading (waitForIframeLoad=false) Feb 28, 2024

github-actions bot deployed to Netlify February 28, 2024 20:27 View deployment

github-actions bot deployed to EndToEndTests February 28, 2024 20:45 View deployment

wait until widget loading is over before comparing screenshots

df821ca

Signed-off-by: Timo K <toger5@hotmail.de>

toger5 force-pushed the toger5/widget-loading-patch branch from d4a7ec9 to df821ca Compare February 29, 2024 11:59

github-actions bot deployed to Netlify February 29, 2024 12:02 View deployment

github-actions bot deployed to EndToEndTests February 29, 2024 12:20 View deployment

fix waitForIFrame=true widgets

cbf98c2

Signed-off-by: Timo K <toger5@hotmail.de>

github-actions bot deployed to Netlify February 29, 2024 13:12 View deployment

github-actions bot deployed to EndToEndTests February 29, 2024 13:30 View deployment

test

0691d5a

Signed-off-by: Timo K <toger5@hotmail.de>

github-actions bot deployed to Netlify February 29, 2024 13:39 View deployment

github-actions bot deployed to EndToEndTests February 29, 2024 13:59 View deployment

always start with loading true. + cleanup

780ce48

Signed-off-by: Timo K <toger5@hotmail.de>

github-actions bot deployed to Netlify March 1, 2024 11:17 View deployment

github-actions bot deployed to EndToEndTests March 1, 2024 11:34 View deployment

simplify loading

409535a

Signed-off-by: Timo K <toger5@hotmail.de>

toger5 force-pushed the toger5/widget-loading-patch branch from 3f6402f to 409535a Compare March 1, 2024 12:08

github-actions bot deployed to Netlify March 1, 2024 12:11 View deployment

update snapshots (start not in loading state for waitForIframe = true…

1c9df2d

… widgets) Signed-off-by: Timo K <toger5@hotmail.de>

github-actions bot deployed to Netlify March 1, 2024 12:27 View deployment

toger5 commented Mar 1, 2024

View reviewed changes

github-actions bot deployed to EndToEndTests March 1, 2024 12:45 View deployment

toger5 requested a review from dbkr March 5, 2024 12:30

Merge branch 'develop' into toger5/widget-loading-patch

17ab67f

github-actions bot deployed to Netlify March 7, 2024 15:42 View deployment

github-actions bot deployed to EndToEndTests March 7, 2024 16:00 View deployment

dbkr approved these changes Mar 11, 2024

View reviewed changes

toger5 added this pull request to the merge queue Mar 12, 2024

Merged via the queue into develop with commit 396829e Mar 12, 2024
22 checks passed

toger5 deleted the toger5/widget-loading-patch branch March 12, 2024 17:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Element Call: fix widget shown while its still loading (`waitForIframeLoad=false`) #12292

Element Call: fix widget shown while its still loading (`waitForIframeLoad=false`) #12292

toger5 commented Feb 27, 2024

dbkr left a comment

toger5 commented Feb 28, 2024

toger5 Mar 1, 2024

Element Call: fix widget shown while its still loading (waitForIframeLoad=false) #12292

Element Call: fix widget shown while its still loading (waitForIframeLoad=false) #12292

Conversation

toger5 commented Feb 27, 2024

Checklist

dbkr left a comment

Choose a reason for hiding this comment

toger5 commented Feb 28, 2024

toger5 Mar 1, 2024

Choose a reason for hiding this comment

Element Call: fix widget shown while its still loading (`waitForIframeLoad=false`) #12292

Element Call: fix widget shown while its still loading (`waitForIframeLoad=false`) #12292