MSC3925: m.replace aggregation with full event #3925

benkuly · 2022-11-03T16:47:58Z

rendered

Instead of always complaining, here is my first MSC 😉

FCP tickyboxes
Implementations: synapse, ele-web

turt2live · 2022-11-03T19:20:52Z

@benkuly don't forget to sign off on the changes for if this eventually gets accepted please :)

benkuly · 2022-11-04T07:55:10Z

@benkuly don't forget to sign off on the changes for if this eventually gets accepted please :)

Thank you, is done now.

proposals/3925-replace-aggregation-with-full-event.md

Signed-off-by: benkuly <kontakt@folivo.net>

typos Signed-off-by: benkuly <kontakt@folivo.net>

added MSC number Signed-off-by: benkuly <kontakt@folivo.net>

Co-authored-by: Jonas Platte <jplatte+git@posteo.de> Signed-off-by: benkuly <kontakt@folivo.net>

richvdh

Thanks! I agree with the proposal, but I'm not sure I agree with all the reasons, and the proposal could do with some clarifications.

proposals/3925-replace-aggregation-with-full-event.md

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

@richvdh

suggested by @richvdh

mscbot · 2023-02-16T07:27:18Z

🔔 This is now entering its final comment period, as per the review above. 🔔

mscbot · 2023-02-21T07:27:29Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

richvdh · 2023-02-21T18:03:23Z

Spec PR: matrix-org/matrix-spec#1440

per matrix-org/matrix-spec-proposals#3925

richvdh · 2023-03-21T15:59:41Z

merged!

Synapse 1.80.0 (2023-03-28) =========================== No significant changes since 1.80.0rc2. Synapse 1.80.0rc2 (2023-03-22) ============================== Bugfixes -------- - Fix a bug in which the [`POST /_matrix/client/v3/rooms/{roomId}/report/{eventId}`](https://spec.matrix.org/v1.6/client-server-api/#post_matrixclientv3roomsroomidreporteventid) endpoint would return the wrong error if the user did not have permission to view the event. This aligns Synapse's implementation with [MSC2249](matrix-org/matrix-spec-proposals#2249). ([\#15298](matrix-org/synapse#15298), [\#15300](matrix-org/synapse#15300)) - Fix a bug introduced in Synapse 1.75.0rc1 where the [SQLite port_db script](https://matrix-org.github.io/synapse/latest/postgres.html#porting-from-sqlite) would fail to open the SQLite database. ([\#15301](matrix-org/synapse#15301)) Synapse 1.80.0rc1 (2023-03-21) ============================== Features -------- - Stabilise support for [MSC3966](matrix-org/matrix-spec-proposals#3966): `event_property_contains` push condition. ([\#15187](matrix-org/synapse#15187)) - Implement [MSC2659](matrix-org/matrix-spec-proposals#2659): application service ping endpoint. Contributed by Tulir @ Beeper. ([\#15249](matrix-org/synapse#15249)) - Allow loading `/register/available` endpoint on workers. ([\#15268](matrix-org/synapse#15268)) - Improve performance of creating and authenticating events. ([\#15195](matrix-org/synapse#15195)) - Add topic and name events to group of events that are batch persisted when creating a room. ([\#15229](matrix-org/synapse#15229)) Bugfixes -------- - Fix a long-standing bug in which the user directory would assume any remote membership state events represent a profile change. ([\#14755](matrix-org/synapse#14755), [\#14756](matrix-org/synapse#14756)) - Implement [MSC3873](matrix-org/matrix-spec-proposals#3873) to fix a long-standing bug where properties with dots were handled ambiguously in push rules. ([\#15190](matrix-org/synapse#15190)) - Faster joins: Fix a bug introduced in Synapse 1.66 where spurious "Failed to find memberships ..." errors would be logged. ([\#15232](matrix-org/synapse#15232)) - Fix a long-standing error when sending message into deleted room. ([\#15235](matrix-org/synapse#15235)) Updates to the Docker image --------------------------- - Ensure the Dockerfile builds on platforms that don't have a `cryptography` wheel. ([\#15239](matrix-org/synapse#15239)) - Mirror images to the GitHub Container Registry (`ghcr.io/matrix-org/synapse`). ([\#15281](matrix-org/synapse#15281), [\#15282](matrix-org/synapse#15282)) Improved Documentation ---------------------- - Add a missing endpoint to the workers documentation. ([\#15223](matrix-org/synapse#15223)) Internal Changes ---------------- - Add additional functionality to declaring worker types when starting Complement in worker mode. ([\#14921](matrix-org/synapse#14921)) - Add `Synapse-Trace-Id` to `access-control-expose-headers` header. ([\#14974](matrix-org/synapse#14974)) - Make the `HttpTransactionCache` use the `Requester` in addition of the just the `Request` to build the transaction key. ([\#15200](matrix-org/synapse#15200)) - Improve log lines when purging rooms. ([\#15222](matrix-org/synapse#15222)) - Improve type hints. ([\#15230](matrix-org/synapse#15230), [\#15231](matrix-org/synapse#15231), [\#15238](matrix-org/synapse#15238)) - Move various module API callback registration methods to a dedicated class. ([\#15237](matrix-org/synapse#15237)) - Configure GitHub Actions for merge queues. ([\#15244](matrix-org/synapse#15244)) - Add schema comments about the `destinations` and `destination_rooms` tables. ([\#15247](matrix-org/synapse#15247)) - Skip processing of auto-join room behaviour if there are no auto-join rooms configured. ([\#15262](matrix-org/synapse#15262)) - Remove unused store method `_set_destination_retry_timings_emulated`. ([\#15266](matrix-org/synapse#15266)) - Reorganize URL preview code. ([\#15269](matrix-org/synapse#15269)) - Clean-up direct TCP replication code. ([\#15272](matrix-org/synapse#15272), [\#15274](matrix-org/synapse#15274)) - Make `configure_workers_and_start` script used in Complement tests compatible with older versions of Python. ([\#15275](matrix-org/synapse#15275)) - Add a `/versions` flag for [MSC3952](matrix-org/matrix-spec-proposals#3952). ([\#15293](matrix-org/synapse#15293)) - Bump hiredis from 2.2.1 to 2.2.2. ([\#15252](matrix-org/synapse#15252)) - Bump serde from 1.0.152 to 1.0.155. ([\#15253](matrix-org/synapse#15253)) - Bump pysaml2 from 7.2.1 to 7.3.1. ([\#15254](matrix-org/synapse#15254)) - Bump msgpack from 1.0.4 to 1.0.5. ([\#15255](matrix-org/synapse#15255)) - Bump gitpython from 3.1.30 to 3.1.31. ([\#15256](matrix-org/synapse#15256)) - Bump cryptography from 39.0.1 to 39.0.2. ([\#15257](matrix-org/synapse#15257)) - Bump pydantic from 1.10.4 to 1.10.6. ([\#15286](matrix-org/synapse#15286)) - Bump serde from 1.0.155 to 1.0.157. ([\#15287](matrix-org/synapse#15287)) - Bump anyhow from 1.0.69 to 1.0.70. ([\#15288](matrix-org/synapse#15288)) - Bump txredisapi from 1.4.7 to 1.4.9. ([\#15289](matrix-org/synapse#15289)) - Bump pygithub from 1.57 to 1.58.1. ([\#15290](matrix-org/synapse#15290)) - Bump types-requests from 2.28.11.12 to 2.28.11.15. ([\#15291](matrix-org/synapse#15291)) Synapse 1.79.0 (2023-03-14) =========================== No significant changes since 1.79.0rc2. Synapse 1.79.0rc2 (2023-03-13) ============================== Bugfixes -------- - Fix a bug introduced in Synapse 1.79.0rc1 where attempting to register a `on_remove_user_third_party_identifier` module API callback would be a no-op. ([\#15227](matrix-org/synapse#15227)) - Fix a rare bug introduced in Synapse 1.73 where events could remain unsent to other homeservers after a faster-join to a room. ([\#15248](matrix-org/synapse#15248)) Internal Changes ---------------- - Refactor `filter_events_for_server`. ([\#15240](matrix-org/synapse#15240)) Synapse 1.79.0rc1 (2023-03-07) ============================== Features -------- - Add two new Third Party Rules module API callbacks: [`on_add_user_third_party_identifier`](https://matrix-org.github.io/synapse/v1.79/modules/third_party_rules_callbacks.html#on_add_user_third_party_identifier) and [`on_remove_user_third_party_identifier`](https://matrix-org.github.io/synapse/v1.79/modules/third_party_rules_callbacks.html#on_remove_user_third_party_identifier). ([\#15044](matrix-org/synapse#15044)) - Experimental support for [MSC3967](matrix-org/matrix-spec-proposals#3967) to not require UIA for setting up cross-signing on first use. ([\#15077](matrix-org/synapse#15077)) - Add media information to the command line [user data export tool](https://matrix-org.github.io/synapse/v1.79/usage/administration/admin_faq.html#how-can-i-export-user-data). ([\#15107](matrix-org/synapse#15107)) - Add an [admin API](https://matrix-org.github.io/synapse/latest/usage/administration/admin_api/index.html) to delete a [specific event report](https://spec.matrix.org/v1.6/client-server-api/#reporting-content). ([\#15116](matrix-org/synapse#15116)) - Add support for knocking to workers. ([\#15133](matrix-org/synapse#15133)) - Allow use of the `/filter` Client-Server APIs on workers. ([\#15134](matrix-org/synapse#15134)) - Update support for [MSC2677](matrix-org/matrix-spec-proposals#2677): remove support for server-side aggregation of reactions. ([\#15172](matrix-org/synapse#15172)) - Stabilise support for [MSC3758](matrix-org/matrix-spec-proposals#3758): `event_property_is` push condition. ([\#15185](matrix-org/synapse#15185)) Bugfixes -------- - Fix a bug introduced in Synapse 1.75 that caused experimental support for deleting account data to raise an internal server error while using an account data writer worker. ([\#14869](matrix-org/synapse#14869)) - Fix a long-standing bug where Synapse handled an unspecced field on push rules. ([\#15088](matrix-org/synapse#15088)) - Fix a long-standing bug where a URL preview would break if the discovered oEmbed failed to download. ([\#15092](matrix-org/synapse#15092)) - Fix a long-standing bug where an initial sync would not respond to changes to the list of ignored users if there was an initial sync cached. ([\#15163](matrix-org/synapse#15163)) - Add the `transaction_id` in the events included in many endpoints' responses. ([\#15174](matrix-org/synapse#15174)) - Fix a bug introduced in Synapse 1.78.0 where requests to claim dehydrated devices would fail with a `405` error. ([\#15180](matrix-org/synapse#15180)) - Stop applying edits when bundling aggregations, per [MSC3925](matrix-org/matrix-spec-proposals#3925). ([\#15193](matrix-org/synapse#15193)) - Fix a long-standing bug where the user directory search was not case-insensitive for accented characters. ([\#15143](matrix-org/synapse#15143)) Updates to the Docker image --------------------------- - Improve startup logging in the with-workers Docker image. ([\#15186](matrix-org/synapse#15186)) Improved Documentation ---------------------- - Document how to use caches in a module. ([\#14026](matrix-org/synapse#14026)) - Clarify which worker processes the ThirdPartyRules' [`on_new_event`](https://matrix-org.github.io/synapse/v1.78/modules/third_party_rules_callbacks.html#on_new_event) module API callback runs on. ([\#15071](matrix-org/synapse#15071)) - Document using [Shibboleth](https://www.shibboleth.net/) as an OpenID Provider. ([\#15112](matrix-org/synapse#15112)) - Correct reference to `federation_verify_certificates` in configuration documentation. ([\#15139](matrix-org/synapse#15139)) - Correct small documentation errors in some `MatrixFederationHttpClient` methods. ([\#15148](matrix-org/synapse#15148)) - Correct the description of the behavior of `registration_shared_secret_path` on startup. ([\#15168](matrix-org/synapse#15168)) Deprecations and Removals ------------------------- - Deprecate the `on_threepid_bind` module callback, to be replaced by [`on_add_user_third_party_identifier`](https://matrix-org.github.io/synapse/v1.79/modules/third_party_rules_callbacks.html#on_add_user_third_party_identifier). See [upgrade notes](https://github.com/matrix-org/synapse/blob/release-v1.79/docs/upgrade.md#upgrading-to-v1790). ([\#15044](matrix-org/synapse#15044)) - Remove the unspecced `room_alias` field from the [`/createRoom`](https://spec.matrix.org/v1.6/client-server-api/#post_matrixclientv3createroom) response. ([\#15093](matrix-org/synapse#15093)) - Remove the unspecced `PUT` on the `/knock/{roomIdOrAlias}` endpoint. ([\#15189](matrix-org/synapse#15189)) - Remove the undocumented and unspecced `type` parameter to the `/thumbnail` endpoint. ([\#15137](matrix-org/synapse#15137)) - Remove unspecced and buggy `PUT` method on the unstable `/rooms/<room_id>/batch_send` endpoint. ([\#15199](matrix-org/synapse#15199)) Internal Changes ---------------- - Run the integration test suites with the asyncio reactor enabled in CI. ([\#14101](matrix-org/synapse#14101)) - Batch up storing state groups when creating a new room. ([\#14918](matrix-org/synapse#14918)) - Update [MSC3952](matrix-org/matrix-spec-proposals#3952) support based on changes to the MSC. ([\#15051](matrix-org/synapse#15051)) - Refactor writing json data in `FileExfiltrationWriter`. ([\#15095](matrix-org/synapse#15095)) - Tighten the login ratelimit defaults. ([\#15135](matrix-org/synapse#15135)) - Fix a typo in an experimental config setting. ([\#15138](matrix-org/synapse#15138)) - Refactor the media modules. ([\#15146](matrix-org/synapse#15146), [\#15175](matrix-org/synapse#15175)) - Improve type hints. ([\#15164](matrix-org/synapse#15164)) - Move `get_event_report` and `get_event_reports_paginate` from `RoomStore` to `RoomWorkerStore`. ([\#15165](matrix-org/synapse#15165)) - Remove dangling reference to being a reference implementation in docstring. ([\#15167](matrix-org/synapse#15167)) - Add an option to force a rebuild of the "editable" complement image. ([\#15184](matrix-org/synapse#15184)) - Use nightly rustfmt in CI. ([\#15188](matrix-org/synapse#15188)) - Add a `get_next_txn` method to `StreamIdGenerator` to match `MultiWriterIdGenerator`. ([\#15191](matrix-org/synapse#15191)) - Combine `AbstractStreamIdTracker` and `AbstractStreamIdGenerator`. ([\#15192](matrix-org/synapse#15192)) - Automatically fix errors with `ruff`. ([\#15194](matrix-org/synapse#15194)) - Refactor database transaction for query users' devices to reduce database pool contention. ([\#15215](matrix-org/synapse#15215)) - Correct `test_icu_word_boundary_punctuation` so that it passes with the ICU versions available in Alpine and macOS. ([\#15177](matrix-org/synapse#15177)) <details><summary>Locked dependency updates</summary> - Bump actions/checkout from 2 to 3. ([\#15155](matrix-org/synapse#15155)) - Bump black from 22.12.0 to 23.1.0. ([\#15103](matrix-org/synapse#15103)) - Bump dawidd6/action-download-artifact from 2.25.0 to 2.26.0. ([\#15152](matrix-org/synapse#15152)) - Bump docker/login-action from 1 to 2. ([\#15154](matrix-org/synapse#15154)) - Bump matrix-org/backend-meta from 1 to 2. ([\#15156](matrix-org/synapse#15156)) - Bump ruff from 0.0.237 to 0.0.252. ([\#15159](matrix-org/synapse#15159)) - Bump serde_json from 1.0.93 to 1.0.94. ([\#15214](matrix-org/synapse#15214)) - Bump types-commonmark from 0.9.2.1 to 0.9.2.2. ([\#15209](matrix-org/synapse#15209)) - Bump types-opentracing from 2.4.10.1 to 2.4.10.3. ([\#15158](matrix-org/synapse#15158)) - Bump types-pillow from 9.4.0.13 to 9.4.0.17. ([\#15211](matrix-org/synapse#15211)) - Bump types-psycopg2 from 2.9.21.4 to 2.9.21.8. ([\#15210](matrix-org/synapse#15210)) - Bump types-pyopenssl from 22.1.0.2 to 23.0.0.4. ([\#15213](matrix-org/synapse#15213)) - Bump types-setuptools from 67.3.0.1 to 67.4.0.3. ([\#15160](matrix-org/synapse#15160)) - Bump types-setuptools from 67.4.0.3 to 67.5.0.0. ([\#15212](matrix-org/synapse#15212)) - Bump typing-extensions from 4.4.0 to 4.5.0. ([\#15157](matrix-org/synapse#15157)) </details>

per matrix-org/matrix-spec-proposals#3925

benkuly changed the title ~~m.replace aggregation with full event~~ MSC3925 m.replace aggregation with full event Nov 3, 2022

benkuly changed the title ~~MSC3925 m.replace aggregation with full event~~ MSC3925: m.replace aggregation with full event Nov 3, 2022

benkuly mentioned this pull request Nov 3, 2022

Inconsistency for edits to encrypted events matrix-org/matrix-spec#1299

Closed

turt2live added proposal A matrix spec change proposal client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Nov 3, 2022

benkuly force-pushed the main branch from b6e87fe to d7e89fa Compare November 4, 2022 07:53

jplatte reviewed Nov 4, 2022

View reviewed changes

proposals/3925-replace-aggregation-with-full-event.md Outdated Show resolved Hide resolved

proposals/3925-replace-aggregation-with-full-event.md Outdated Show resolved Hide resolved

benkuly force-pushed the main branch 2 times, most recently from 8dde1fb to 7f6b8e0 Compare November 4, 2022 08:39

benkuly and others added 6 commits November 4, 2022 09:48

init m.replace aggregation with full event

116eb4e

Signed-off-by: benkuly <kontakt@folivo.net>

Rename tmp.md to 3925-replace-aggregation-with-full-event.md

88c434d

Signed-off-by: benkuly <kontakt@folivo.net>

Update 3925-replace-aggregation-with-full-event.md

5a54a03

typos Signed-off-by: benkuly <kontakt@folivo.net>

Update 3925-replace-aggregation-with-full-event.md

a065b00

added MSC number Signed-off-by: benkuly <kontakt@folivo.net>

Update proposals/3925-replace-aggregation-with-full-event.md

4f5ecde

Co-authored-by: Jonas Platte <jplatte+git@posteo.de> Signed-off-by: benkuly <kontakt@folivo.net>

Update proposals/3925-replace-aggregation-with-full-event.md

6ea5486

Co-authored-by: Jonas Platte <jplatte+git@posteo.de> Signed-off-by: benkuly <kontakt@folivo.net>

benkuly force-pushed the main branch from 7f6b8e0 to 6ea5486 Compare November 4, 2022 08:48

richvdh self-requested a review November 4, 2022 14:39

richvdh requested changes Nov 8, 2022

View reviewed changes

benkuly and others added 8 commits November 8, 2022 16:34

Update proposals/3925-replace-aggregation-with-full-event.md

09602eb

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

redact instead of delete

3876a46

Update proposals/3925-replace-aggregation-with-full-event.md

97dfdce

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

Update proposals/3925-replace-aggregation-with-full-event.md

c0ec33d

Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

Merge branch 'main' of github.com:benkuly/matrix-spec-proposals

f7fa717

word wrap 80

0bba4e4

remove immutable argument

db0ca3e

add alternative from matrix-org/matrix-spec#1299 (comment)

ff6fc37

benkuly added 2 commits February 8, 2023 09:51

remove superfluous event content field

64da169

add some details to potential issues

3d9e2ab

suggested by @richvdh

mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Feb 16, 2023

turt2live moved this from Ready for FCP ticks to In FCP in Spec Core Team Backlog Feb 16, 2023

mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Feb 21, 2023

turt2live merged commit 13935ec into matrix-org:main Feb 21, 2023

turt2live moved this from In FCP to Requires spec writing in Spec Core Team Backlog Feb 21, 2023

richvdh mentioned this pull request Feb 21, 2023

Change the server aggregation for edits matrix-org/matrix-spec#1440

Merged

richvdh moved this from Requires spec writing to Requires spec PR review in Spec Core Team Backlog Feb 21, 2023

turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed finished-final-comment-period labels Feb 21, 2023

jplatte mentioned this pull request Feb 22, 2023

Implement MSC3925 ruma/ruma#1488

Closed

turt2live assigned richvdh Feb 27, 2023

richvdh added a commit to matrix-org/matrix-spec that referenced this pull request Mar 21, 2023

Change the server aggregation for edits (#1440)

acb631d

per matrix-org/matrix-spec-proposals#3925

richvdh moved this from Requires spec PR review to Done to some definition in Spec Core Team Backlog Mar 21, 2023

richvdh added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Mar 21, 2023

zecakeh mentioned this pull request Mar 23, 2023

Implement Matrix v1.7 changes ruma/ruma#1520

Closed

47 tasks

clokep pushed a commit to clokep/matrix-spec that referenced this pull request May 3, 2023

Change the server aggregation for edits (matrix-org#1440)

4cba6d8

per matrix-org/matrix-spec-proposals#3925

This was referenced May 18, 2023

Excessive calls to GET /relations and GET /event, with MSC3981 enabled and working element-hq/element-web#25395

Closed

Declare support for Matrix v1.7 matrix-org/synapse#15661

Closed

S7evinK mentioned this pull request Oct 2, 2023

Declare support for Matrix 1.7 matrix-org/dendrite#3225

Open

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MSC3925: m.replace aggregation with full event #3925

MSC3925: m.replace aggregation with full event #3925

benkuly commented Nov 3, 2022 •

edited by richvdh

Loading

turt2live commented Nov 3, 2022

benkuly commented Nov 4, 2022

richvdh left a comment

mscbot commented Feb 16, 2023

mscbot commented Feb 21, 2023

richvdh commented Feb 21, 2023

richvdh commented Mar 21, 2023

MSC3925: m.replace aggregation with full event #3925

MSC3925: m.replace aggregation with full event #3925

Conversation

benkuly commented Nov 3, 2022 • edited by richvdh Loading

turt2live commented Nov 3, 2022

benkuly commented Nov 4, 2022

richvdh left a comment

Choose a reason for hiding this comment

mscbot commented Feb 16, 2023

mscbot commented Feb 21, 2023

richvdh commented Feb 21, 2023

richvdh commented Mar 21, 2023

benkuly commented Nov 3, 2022 •

edited by richvdh

Loading