Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italicise primes and brackets in state res desc #1043

Merged
merged 2 commits into from
May 10, 2022
Merged

Italicise primes and brackets in state res desc #1043

merged 2 commits into from
May 10, 2022

Conversation

DMRobertson
Copy link
Contributor

@DMRobertson DMRobertson commented May 3, 2022

I don't like it but it seems to make things look decent in Firefox.
This is probably good enough---we're not Knuth, after all.

To the reviewer: please check that this looks like an improvement for a Chromium-based browser too.

Additionally I have avoided the use of *E*'s as in "E's prev_events"
since the apostrophe looks poor here.

Resolves #774.
An alternative to #1040.

Preview: https://pr1043--matrix-spec-previews.netlify.app

David Robertson added 2 commits May 3, 2022 13:59
I don't like it but it seems to make things look decent in Firefox.
This is probably good enough---we're not Knuth, after all.

Additionally I have avoided the use of `*E*'s` as in "E's prev_events"
since the apostrophe looks poor here.

Resolves #774.
An alternative to #1040.
@DMRobertson
Copy link
Contributor Author

Firefox before:

Screenshot from 2022-05-03 14-09-44

Firefox after:

Screenshot from 2022-05-03 14-09-03

@DMRobertson DMRobertson marked this pull request as ready for review May 3, 2022 13:10
@DMRobertson DMRobertson requested a review from a team as a code owner May 3, 2022 13:10
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks closer to how it was probably intended, but a RST->MD transition long ago made Bad Decisions for us. Approving this while we determine if the alternative naming is better for the long run.

@turt2live turt2live merged commit 81d61d8 into matrix-org:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prime characters (') are almost invisible
2 participants