Add link checker to CI #1329
Merged
Add link checker to CI #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bunch of broken links I found
The link checker doesn't understand that we dynamically re-assign element IDs at load time, so was failing for a few links that were technically valid (though presumably still broken for any client not using JS). Work around this by manually setting a few anchors, linking to other nearby bits of text, or just changing heading titles.
uhoreg
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure that we don't accumulate dead links, add a step in CI to check the rendered output for broken links.
Based on #1330.
Also includes some tweaks to ensure that we have unique anchors where we need them. See the commit comment on
9e83605.
Preview: https://pr1329--matrix-spec-previews.netlify.app