-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only include endpoint path in <summary>
#1446
Only include endpoint path in <summary>
#1446
Conversation
Seems to fix #1352. I can't remember the details but I vaguely remember from the last time I looked into this that there's something about being inside a Edit: #1358 (comment) |
This comment was marked as outdated.
This comment was marked as outdated.
This seems to be local to me and was because I had uncommitted changes in themes/docsy. |
h1 { | ||
margin: 0; | ||
/* Ensure the disclosure control is vertically centred with the header text. */ | ||
vertical-align: middle; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this relies on the first line of the summary being an <h1>
, but that's probably an assumption we can live with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could maybe do summary > *
or summary > :first-child
if this bites us in the future/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Other details elements have this wierdly oversized summary too, e.g https://spec.matrix.org/v1.7/client-server-api/#mroomcanonical_alias |
I previously made this change for HTTP endpoints in #1446. It seems there are other places where we have over-sized `<summary>` elements. I would like to elimintate those too, as grumbled about in #1358 (comment) and #1352 (comment)
As threatened on #1358 (comment) and #1352 (comment). (If nothing else, I seem to be consistent.)
Fixes #1352.
Preview: https://pr1446--matrix-spec-previews.netlify.app