-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stickers have incomplete / invalid documentation around encryption #1667
Comments
I can't find evidence that stickers were designed to be copies of This would normally require an MSC to fix, but I think it's much more important for us to get extensible events through FCP instead. This would fix the image representation issues in the process. |
I don't understand what this means for my suggestion of sending a PR adjusting the spec to what at least Mautrix implements. Would that be accepted, or not? |
I can't speak on behalf of the entire spec core team on the issue, but I suspect it would not be accepted. The stickers feature was intended to promote reuse of MXC URIs, which translates to unencrypted files. It's considered a spec bug that we don't have encrypted sticker support, but not in a way where we can avoid an MSC. Opening an MSC to add Mautrix's implementation would largely get deprioritized in favour of extensible events, given limited bandwidth from the SCT. |
Okay, then the |
Possibly, or we focus our efforts on extensible events and deprecate all event definitions in the client-server API :D I'd honestly suggest we put our energy towards ensuring Extensible Events (and the associated Events Specification, separated from the Client-Server API) is what we're looking for feature-wise. The events spec doesn't yet have an MSC, but should hopefully have something soon. |
What would this mean in practice? Even extensible events have some standard event definitions, no? So I'm not quite sure what's being suggested. |
Link to problem area: https://spec.matrix.org/latest/client-server-api/#msticker
Issue
According to the spec,
m.sticker
's content has a mandatoryurl
field. However according to tulir,m.sticker
was supposed to be likem.room.message
with"msgtype": "m.image"
, just with a different event type such that theurl
field is only required for unencrypted stickers and there's afile
object for encrypted ones instead (which is not specced at all).Can I send a PR adjusting the spec to match that understanding, or is more discussion / an MSC or somesuch necessary?
cc MSC1158 (Sticker messages)
The text was updated successfully, but these errors were encountered: