Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to valid URL syntax #17

Open
ara4n opened this issue Mar 31, 2017 · 9 comments
Open

Switch to valid URL syntax #17

ara4n opened this issue Mar 31, 2017 · 9 comments

Comments

@ara4n
Copy link
Member

ara4n commented Mar 31, 2017

Technically you're meant to escape # and @ symbols within URL paths/fragments. The fact we don't causes woes like those described on https://meta.discourse.org/t/broken-links-blank-page-with-appearing-in-url/52640/10

@ara4n
Copy link
Member Author

ara4n commented Mar 31, 2017

The solution to this is probably to switch over to compact URLs everywhere as per issue #10.

@uhoreg
Copy link
Member

uhoreg commented Mar 31, 2017

The problem with the compact URLs is that a URL like https://matrix.to/@matthew:matrix.org would 1) send the entire URL to the server, which may be a privacy concern, and 2) require some server-side help, which would make it harder for people to host it themselves (e.g. matrix.to currently 404s on that link instead of loading the main matrix.to page)

@StefanBrand
Copy link

StefanBrand commented Mar 31, 2017

Usually one would handle it like this, I guess:

https://matrix.to?r=#matrix:matrix.org

https://matrix.to?u=@matthew:matrix.org

@ara4n
Copy link
Member Author

ara4n commented Mar 31, 2017 via email

@phaux
Copy link

phaux commented Feb 11, 2018

How about /u/username/server.name for users and /r/roomname/server.name for rooms?

@t3chguy
Copy link
Member

t3chguy commented Feb 11, 2018

@phaux what about roomId ! vs roomAlias # and also event permalinks !/$

@eMPee584
Copy link

🥁

@skepticalwaves
Copy link

Another big problem with the "#" syntax is that this makes the matrix.to implementation impossible to proxy with apache/nginx as the full URL doesn't get sent as part of the "GET".

https://stackoverflow.com/questions/9484852/hash-character-in-urls-accessing-and-redirecting-in-apache

@t3chguy
Copy link
Member

t3chguy commented Sep 26, 2022

as the full URL doesn't get sent as part of the "GET".

This is by design. To prevent the host being able to sniff on usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants