Remove isinstance test when converting to boolean

matrix-org · Aug 9, 2023 · ddc91e8 · ddc91e8
1 parent 0246483
commit ddc91e8
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/synapse/storage/databases/main/registration.py b/synapse/storage/databases/main/registration.py
@@ -239,8 +239,7 @@ def get_user_by_id_txn(txn: LoggingTransaction) -> Optional[Dict[str, Any]]:
                 "locked",
             ]
             for column in boolean_columns:
-                if not isinstance(row[column], bool):
-                    row[column] = bool(row[column])
+                row[column] = bool(row[column])
 
         return row
 
@@ -1141,10 +1140,8 @@ async def get_user_locked_status(self, user_id: str) -> bool:
             desc="get_user_locked_status",
         )
 
-        # Convert the integer into a boolean.
-        if not isinstance(res, bool):
-            res = bool(res)
-        return res
+        # Convert the potential integer into a boolean.
+        return bool(res)
 
     async def get_threepid_validation_session(
         self,